-
Notifications
You must be signed in to change notification settings - Fork 6
add depth absolute/relative encoding #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this last comment is solved + the pr description updated, we're gonna be ready to merge. I'll also ask @jsalotti to review since it could happen to use theses methods soon.
@jsalotti Can you quickly review this merge request. It propose some method that you might use at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The transformations are not consistent. Calling
encode_absolute
afterencode_inverse
will not give you the original value. This is due to the order in which you apply substraction and division. encode_inverse
does not seem consistent with the convention of this paper. They apply scale and shift directly on idepth, whereas you apply it on depth before inversion. Is it on purpose ?- in
encode_inverse
, it seems that the depth is modified in place instead of creating a copy to return an inverse depth
It seems that we had a problem with functions name. Calling DPT with dpt = DPT(invert=False)
depth = dpt(frame) # inverted predicted depth
depth = depth.encode_absolute(shift=shift, scale=scale) # absolute depth
|
@Data-Iab Sounds good. I think there is still a last comment unresolved |
Two methods added to Depth:
One method added to AugTensor: