Skip to content

79 coco detection splitmixin #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 9, 2021
Merged

79 coco detection splitmixin #122

merged 7 commits into from
Nov 9, 2021

Conversation

Johansmm
Copy link
Contributor

New alodataset : CocoExtendDetectionDataset. New version of CocoDetectionDataset with the following new features:

  • SplitMixin mode compatibility
  • Include stuff categories from stuff_annotations.json
  • Return multiples labels found in annotations (supercategory, isthing, iscrowd).

Also, update of CocoDetectionDataset to incorporate return multiples labels feat.

Closes #79 #97

@Johansmm Johansmm linked an issue Oct 21, 2021 that may be closed by this pull request
CocoDataset for multiples labels #97
Closed
@Johansmm Johansmm requested a review from thibo73800 October 21, 2021 09:30
@Johansmm Johansmm self-assigned this Oct 21, 2021
@Johansmm Johansmm added alodataset enhancement New feature or request labels Oct 21, 2021
thibo73800
thibo73800 requested changes Oct 29, 2021
View reviewed changes
alodataset/coco_extend_detection_dataset.py Outdated
from aloscene import Frame


class CocoExtendDetectionDataset(CocoDetectionDataset, SplitMixin):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CocoExtend refer to THE coco dataset right ? Not sure this name refect this property, it seem this is an extension of coco.
What about:

  • CocoBaseDataset: To handle datasets following the coco format
  • CocoDetectionDataset: to handle THE coco dataset (with crowd, things & stuff) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Johansmm Johansmm requested a review from thibo73800 November 8, 2021 17:04
@thibo73800 thibo73800 merged commit 67acff4 into master Nov 9, 2021
@thibo73800 thibo73800 deleted the 79-coco-detection-splitmixin branch March 10, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibo73800 thibo73800 thibo73800 approved these changes

Assignees

@Johansmm Johansmm

Labels
alodataset enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CocoDataset for multiples labels Update COCO dataset and COCODetection to detr with SplitMix class
2 participants
@Johansmm @thibo73800