Skip to content

feat: add columns information in sankey nodeHeight callback #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add columns information in sankey nodeHeight callback #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9410c2c
feat: add columns information in sankey nodeHeight callback
xiaoluoHe Jul 7, 2025
5bcf490
fix: correct since version
xiaoluoHe Jul 7, 2025
aca1fb8
docs: add changelog
xiaoluoHe Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@visactor/vlayouts/feat-sankey-nodeHeight-callback_2025-07-07-07-16.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vlayouts",
"comment": " feat: add columns information in sankey nodeHeight callback",
"type": "none"
}
],
"packageName": "@visactor/vlayouts"
}
3 changes: 2 additions & 1 deletion packages/vlayouts/src/sankey/interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ export interface SankeyOptions {
/**
* set the height of node
* @since 0.13.0
* @description add columns information since 1.0.8
*/
nodeHeight?: number | ((node: SankeyNodeElement) => number);
nodeHeight?: number | ((node: SankeyNodeElement, columns?: SankeyNodeElement[][]) => number);
/**
* set the height of link
* @since 0.13.0
Expand Down
4 changes: 2 additions & 2 deletions packages/vlayouts/src/sankey/layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ export class SankeyLayout {
const getNodeHeight = isNumber(this.options.nodeHeight)
? (node: SankeyNodeElement) => this.options.nodeHeight as number
: isFunction(this.options.nodeHeight)
? (this.options.nodeHeight as (node: SankeyNodeElement) => number)
? (this.options.nodeHeight as (node: SankeyNodeElement, columns: SankeyNodeElement[][]) => number)
: forceNodeHeight > 0
? (node: SankeyNodeElement) => {
return forceNodeHeight;
Expand Down Expand Up @@ -755,7 +755,7 @@ export class SankeyLayout {
y += gapY;
}

calculatedNodeHeight = getNodeHeight(node);
calculatedNodeHeight = getNodeHeight(node, columns);
nodeHeight = Math.min(Math.max(calculatedNodeHeight, minNodeHeight), maxNodeHeight);

node.y0 = y;
Expand Down
Loading