Feature/fix stereo headphone disambiguation#356
Merged
lakulish merged 2 commits intoValveSoftware:masterfrom Aug 12, 2024
Merged
Conversation
Schroedingers-Cat
force-pushed
the
feature/fix-stereo-headphone-disambiguation
branch
from
fe5782d to
09326bd
Compare
Contributor
Author
|
@lakulish your feedback is welcome! Also, should we merge this, do we also want to change the documentation accordingly? |
Contributor
Author
|
@lakulish any feedback in this MR? |
lakulish
requested changes
Jul 15, 2024
Collaborator
lakulish
left a comment
lakulish
left a comment
There was a problem hiding this comment.
Comments are mostly around variable/function naming. I also have a question as to whether we need to surface anything at all in the Steam Audio Settings.
...ject/SteamAudioUnity/Assets/Plugins/SteamAudio/Scripts/Editor/SteamAudioSettingsInspector.cs
Outdated
Show resolved
Hide resolved
unity/src/project/SteamAudioUnity/Assets/Plugins/SteamAudio/Scripts/Runtime/AudioEngineState.cs
Outdated
Show resolved
Hide resolved
.../src/project/SteamAudioUnity/Assets/Plugins/SteamAudio/Scripts/Runtime/SteamAudioSettings.cs
Outdated
Show resolved
Hide resolved
.../src/project/SteamAudioUnity/Assets/Plugins/SteamAudio/Scripts/Runtime/SteamAudioSettings.cs
Outdated
Show resolved
Hide resolved
lakulish
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a global HRTF option to Steam Audio that allows to disable HRTF rendering for all Steam Audio instances. This solves the problem of FMOD and Unity not differentiating between stereo on speakers (don't use HRTFs) vs stereo on headphones (prefer HRTFs). Game programmers can use the global HRTF option for instance in their game's option menu or automatically set this depending on the presence of a digital headphone or speaker set.
The default value of this new setting is backwards compatible meaning projects using an older Steam Audio version upgrading to a version with these changes will behave as before.
This was originally part of PR #329 but has been moved into a dedicated PR.