Skip to content

ExternalProject_Add avoids touching install directory at configure time #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

evaleev
Copy link
Member

@evaleev evaleev commented Apr 3, 2024

  • eigen3: ExternalProject_add specifies STAMP_DIR and TMP_DIR
  • eigen3, librett, umpire: ExternalProject_add uses FETCHCONTENT_BASE_DIR as PREFIX

resolves #402

@evaleev evaleev changed the title fetching eigen3 via ExternalProject_Add's needs to specify STAMP_DIR and TMP_DIR ExternalProject_Add avoids touching install directory at configure time Apr 3, 2024
@evaleev evaleev merged commit e26379a into master Apr 3, 2024
Copy link
Contributor

@therault therault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested in TTG, and it works.

@evaleev evaleev deleted the evaleev/fix/eigen3-ep-tmpdir branch September 22, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eigen stamp and tmp directories appearing in the install directory
2 participants