Skip to content

fix sparse shape threshold #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Conversation

evaleev
Copy link
Member

@evaleev evaleev commented Mar 3, 2023

handling of thresholds by SparseShape was inconsistent. For example:

  • SparseShape::mask would produce a shape screened using this->my_threshold_, whereas other unary operations would use global threshold
  • SparseShape::update_block would screen the result using global threshold and use this->my_threshold_ to construct the result

Now all unary operations use this->init_threshold() (returning this->my_threshold_) for the result and all binary operations use global threshold.

@evaleev evaleev merged commit 9c186b6 into master Mar 3, 2023
@evaleev evaleev deleted the evaleev/fix/sparse-shape-threshold branch March 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant