Skip to content

fix: linalgpp compile noise #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2022
Merged

fix: linalgpp compile noise #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a357a2
reduce compile noise of {blas,lapack}pp due to addition of (command-l…
evaleev Jun 30, 2022
bde0b65
misc fixups
evaleev Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmake/modules/FindOrFetchBTAS.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,11 @@ if (NOT TARGET BTAS::BTAS)
target_compile_definitions(lapackpp PUBLIC -DLAPACK_FORTRAN_UPPER=1)
else()
if (NOT LINALG_MANGLING STREQUAL lower_)
message(WARNING "Linear algebra libraries' mangling convention not specified; specify -DLINALG_MANGLING={lower,lower_,UPPER}, if needed; will assume lower_")
message(WARNING "Linear algebra libraries' mangling convention not specified; specify -DLINALG_MANGLING={lower,lower_,UPPER}, if needed; BLASPP will try to autodetect")
endif(NOT LINALG_MANGLING STREQUAL lower_)
target_compile_definitions(blaspp PUBLIC -DBLAS_FORTRAN_ADD_=1)
target_compile_definitions(lapackpp PUBLIC -DLAPACK_FORTRAN_ADD_=1)
# these were needed for some configs at some point in the past? But in most cases they just produce compile noise
# target_compile_definitions(blaspp PUBLIC -DBLAS_FORTRAN_ADD_=1)
# target_compile_definitions(lapackpp PUBLIC -DLAPACK_FORTRAN_ADD_=1)
endif()
endif (_linalgpp_use_standard_linalg_kits)

Expand Down
2 changes: 1 addition & 1 deletion doc/dox/dev/Customizing-Arrays.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ public:

// MADNESS compliant serialization
template <typename Archive>
void serialize(const Archive&);
void serialize(Archive&);

}; // class MyLazyTile
```
Expand Down