Skip to content

Conversation

@sabonerune
Copy link
Contributor

内容

CMDの方に書かれていたエンジン起動用のコマンドをENTRYPOINTに移動します。

現在、エンジンの引数を設定するには以下のようにする必要があります。

docker run --publish=127.0.0.1:50021:50021 voicevox_engine gosu user /opt/voicevox_engine/run --host 0.0.0.0 [その他の引数]

これはドキュメント化されていない上に分かりにくいです。

この変更により引数の変更が以下のように簡単になります。

docker run --publish=127.0.0.1:50021:50021 voicevox_engine --host 0.0.0.0 [その他の引数]

関連 Issue

resolve #1800

その他

これは破壊的変更です。

--host 0.0.0.0--use_gpuCMDにあるため引数を変更する場合はほぼ必ず入れる必要があります。
これは今後のPRで改善する予定です。
ref #1800 (comment)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Docker ENTRYPOINT and CMD configuration to improve the separation of concerns between the fixed runtime command and its optional arguments.

  • Moved gosu, user, and /opt/voicevox_engine/run from CMD to ENTRYPOINT for the base runtime
  • Separated runtime arguments (--host, --use_gpu) into CMD directives for easier customization
  • Applied the same pattern to the runtime-nvidia-env stage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントします!

@Hiroshiba
Copy link
Member

@codex この変更に問題がないかレビューしてください。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@aoirint さんもありがとうございました!!

破壊的変更なのでリリース時に案内しようと思います。
ということで忘れないようにリリース手順メモに書いておきました!
VOICEVOX/voicevox_project#85

@Hiroshiba Hiroshiba enabled auto-merge November 4, 2025 15:32
@Hiroshiba Hiroshiba added this pull request to the merge queue Nov 4, 2025
@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Merged via the queue into VOICEVOX:master with commit 607c77e Nov 4, 2025
5 checks passed
@sabonerune sabonerune deleted the feat!/easy-cmd branch November 4, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerイメージでエンジンに簡単に引数を設定できるようにする

3 participants