-
Notifications
You must be signed in to change notification settings - Fork 246
feat!: ENTRYPOINTとCMDを変更して引数の変更を簡単にする
#1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the Docker ENTRYPOINT and CMD configuration to improve the separation of concerns between the fixed runtime command and its optional arguments.
- Moved
gosu,user, and/opt/voicevox_engine/runfrom CMD to ENTRYPOINT for the base runtime - Separated runtime arguments (
--host,--use_gpu) into CMD directives for easier customization - Applied the same pattern to the
runtime-nvidia-envstage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aoirint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメントします!
|
@codex この変更に問題がないかレビューしてください。 |
Hiroshiba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
@aoirint さんもありがとうございました!!
破壊的変更なのでリリース時に案内しようと思います。
ということで忘れないようにリリース手順メモに書いておきました!
VOICEVOX/voicevox_project#85
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
内容
CMDの方に書かれていたエンジン起動用のコマンドをENTRYPOINTに移動します。現在、エンジンの引数を設定するには以下のようにする必要があります。
これはドキュメント化されていない上に分かりにくいです。
この変更により引数の変更が以下のように簡単になります。
関連 Issue
resolve #1800
その他
これは破壊的変更です。
--host 0.0.0.0や--use_gpuはCMDにあるため引数を変更する場合はほぼ必ず入れる必要があります。これは今後のPRで改善する予定です。
ref #1800 (comment)