fix: ソングエディタでvvproj以外のファイルからのインポートが動作していないのを修正 #2693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Collaborator
|
確認不足でした…修正PRありがとうございます！ |
| throw new Error("Track not found."); | ||
| } | ||
| const rawTrack = toRaw(track); | ||
| // TODO: トラックの変換処理を関数化する |
Collaborator
There was a problem hiding this comment.
マージ後ですみません！
ここtoRawがなくなっていますが、大丈夫でしょうか…？
（確認したところ、importedTrack.pitchEditDataなどがProxyのままになってそうでした）
@sevenc-nanashi さん、コメントいただけると…！
Member
There was a problem hiding this comment.
ん〜確かにProxyになってますね...少なくとも問題になりそうな箇所はない（structuredCloneぐらいしかなくて、そしてrfdcで置き換えられてるはず）けど一応Proxyは外した方がいいかもですね。プルリク出します。
Hiroshiba
pushed a commit
that referenced
this pull request
Jun 30, 2025
Co-authored-by: sevenc-nanashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#2675 でfilteredTracksを生成する際にnoteとしてインポートファイルから生成されたtracksを元にしたtrackではなくrawTrackの方を使うようになっていたので、それ以前の様にtrackを使うように戻しました。
関連 Issue
close #2692
スクリーンショット・動画など
その他