fix: e2eテストで使用するエンジンの更新 #2690
Merged
fix: e2eテストで使用するエンジンの更新 #2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the e2e test workflow to use a newer, self-contained engine release and adjust platform asset names.
- Bumps VOICEVOX_ENGINE_VERSION to 0.23.0
- Removes libsndfile1 installation requirement
- Updates matrix asset names for Linux and macOS
Comments suppressed due to low confidence (4)
.github/workflows/test.yml:12
- Hyphen removed before VOICEVOX_ENGINE_VERSION; ensure the env block still conforms to GitHub Actions YAML mapping to avoid syntax errors.
VOICEVOX_ENGINE_VERSION: "0.23.0"
.github/workflows/test.yml:71
- [nitpick] Ensure 'linux-cpu-x64' matches the actual release artifacts and consider standardizing asset naming across platforms for clarity.
voicevox_engine_asset_name: linux-cpu-x64
.github/workflows/test.yml:73
- Switching macOS to only arm64 runners may exclude Intel-based coverage; consider re-adding an x64 matrix entry or making architecture selection configurable.
voicevox_engine_asset_name: macos-arm64
.github/workflows/test.yml:85
- Removed libsndfile installation; confirm the updated engine binary has no dependency on libsndfile, otherwise tests may fail due to missing library.
sudo apt-get install -y xvfb x11-xserver-utils # for electron
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
e2eテストで使用するエンジンを更新します。
これによりLinuxのテスト時にインストールしていたlibsndfile1のインストールが不要になります。
またmacOSのテストで使うエンジンも変更します。
関連 Issue
ref VOICEVOX/voicevox_engine#1528
ref #2112