Fix: mainのCIが落ちてるのを直す #2446
Merged
Fix: mainのCIが落ちてるのを直す #2446
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
sevenc-nanashi
commented
Dec 28, 2024
| } from "@/domain/hotkeyAction"; | ||
|
|
||
| test("すべてのホットキーに初期値が設定されている", async () => { | ||
| const defaultHotkeySettings = getDefaultHotkeySettings(false); |
Member
Author
There was a problem hiding this comment.
このisMacの指定の部分、ぱっと見何やってるか判らないので{ isMac: boolean }を受け取るように死体気持ちがあります
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Hiroshiba
approved these changes
Dec 29, 2024
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！！
やっぱマージキューほしい！！！！！
（approve人数がレビュワー権限とメンテナ権限で違う関係でGithubの仕組みを使えない）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
mainのCIが落ちてるのを直します。
関連 Issue
（なし）
スクリーンショット・動画など
（なし）
その他
（なし）