test: ツールバーのカスタマイズダイアログの可視性チェックを改善 #2441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Dec 27, 2024
Comment on lines
-25
to
+27
Member
Author
There was a problem hiding this comment.
この場合page.waitForTimeout(100)などは不要になるはず。
expect().hoge()がPromiseの場合は自動リトライしてくれるはずなので。
sevenc-nanashi
approved these changes
Dec 27, 2024
Member
sevenc-nanashi
left a comment
sevenc-nanashi
left a comment
There was a problem hiding this comment.
大丈夫だと思います。（落ちてる原因とかを見てもそれっぽそう）
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Member
Author
|
レビューありがとうございます！ これでretryが減るはず！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
にて落ちていたmacOSのテストを改善します。
メニューが閉じきる前にダイアログが表示されると、「ツールバーのカスタマイズ」というテキストが2箇所に現れてテストが落ちるっぽいです。
タイミングによっては落ちないので厄介。
その他