-
Notifications
You must be signed in to change notification settings - Fork 2
feat: masterブランチのサポートを追加 #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Hiroshiba <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for master branch to the preview pages system. The issue was that repositories using master branch (like voicevox_blog) were not appearing in the preview pages because the branch filtering logic only included main and project-* branches.
- Added
masterbranch to the branch filtering condition infetchTargetsfunction - Updated documentation to reflect the new supported branch types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/collectArtifacts.ts | Modified branch filtering logic to include master branch alongside existing main and project-* patterns |
| README.md | Added master to the list of supported target branches in documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hiroshiba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ここ以外に変更箇所あるべきかわからないけど行けてそう感!
sevenc-nanashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
お~ここまでできるんですね。すごい
|
マージします。 |
概要
voicevox_blogリポジトリのmasterブランチがプレビューページに表示されない問題を修正しました。
問題
https://voicevox.github.io/preview-pages/?repo=blog にアクセスした際、masterブランチのリンクが表示されていませんでした。
原因は、
scripts/collectArtifacts.tsのfetchTargets関数がmainブランチとproject-*ブランチのみをフィルタリングしており、masterブランチを含めていなかったためです。変更内容
scripts/collectArtifacts.ts
ブランチフィルター条件に
masterブランチを追加しました:README.md
対象ブランチのリストに
masterを追加し、ドキュメントを実装と一致させました。影響
関連Issue
Fixes #(Issue番号)
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
npm.jsr.ionode /usr/local/bin/pnpm install(dns block)node /usr/local/bin/pnpm install --no-optional(dns block)npm install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Fixes #44
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.