chore: キャッシュのファイル名にrepoKeyを含める #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jun 24, 2025
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！
１つコメントしてますが変更してもそのままでもマージで良さそう！
Comment on lines
63
to
66
| if (!(repo in targetRepos)) { | ||
| log.warn`Unknown repo: ${repo}, skipping...`; | ||
| continue; | ||
| } |
Member
There was a problem hiding this comment.
（どちらでも良さそうなコメント）
ありえないのであればエラーでも良いかも。
全然関係ないけど、AI君かなり気軽にエラーの握りつぶしやフォールバックを書くんですよね。
ということで僕はプロンプトにこんなの書いてます。これ書いてても普通に握りつぶしてくるけど。
* 想定外の挙動は例外を投げよ
* 余計なフォールバックはバグになるため書くな
* エラーは問題の早期発見に繋がる
* 型を合わせるためにifを使う場合も例外を投げよ
* どうしてもフォールバックが必要な場合はログを出せ
Member
Author
|
マージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
タイトル通りです。なくてもrunIdがあるので混ざることはありませんが、一応...
関連 Issue
（なし）
スクリーンショット・動画など
（なし）
その他
（なし）