Skip to content

Rolling Edsilv/utils into the uv #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

Geoffsc
Copy link
Contributor

@Geoffsc Geoffsc commented Jul 18, 2025

#1380

Rolling Edsilv/utils into the uv:

  • added Utils class
  • updated references
  • removed npm package
  • updated webpack config to compile Utils.js outside the bundle
  • updated compiled Utils.js file references

Copy link

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 4:57pm

@demiankatz
Copy link
Contributor

Thanks, @Geoffsc, this seems to be working for me, though the webpack parts may go a little over my head. When I view the preview and inspect the browser console, I don't see a Utils.js getting downloaded, so I'm not sure where that piece fits into the puzzle....

I also tried disabling the download and share options in the footer panel just to confirm that the Bools library is getting exercised correctly. It didn't work for me, but it also doesn't work on the dev branch, so I'm wondering if there's some larger configuration problem at hand (or, equally likely, whether I'm just doing something wrong). That may be a separate rabbit hole for us to fall down....

@Geoffsc
Copy link
Contributor Author

Geoffsc commented Jul 21, 2025

@demiankatz that's a great catch -- I attempted a small webpack config fix but it looks like this will require more effort and possibly multiple webpack configurations to fix, since this would require no longer bundling everything within UV.js. I wonder if it's worth having a dev call specifically for this with other folks who have webpack config experience. Possibly there's an easier fix that is eluding me at the moment!

@demiankatz
Copy link
Contributor

Thanks, @Geoffsc! I think a related question (which I've already partially raised before) is: what is the purpose of mobile.html and production.html? I'm not sure how these files are used, and the hard-coded external dependencies in them concern me. If these are obsolete and can be removed, maybe that will simplify things; if they are needed, it would be good to understand why and how so that we can consider possible improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In testing
Development

Successfully merging this pull request may close these issues.

2 participants