Skip to content

[Cherrypick] Fix test failures on trunk with input system 1.1.1 (#5542) to 2.0.1 verified #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2021
Merged

[Cherrypick] Fix test failures on trunk with input system 1.1.1 (#5542) to 2.0.1 verified #5608

merged 2 commits into from
Nov 5, 2021

Conversation

maryamhonari
Copy link
Contributor

Proposed change(s)

Cherrypick #5542 to fix failures on trunk with the upgrade from input 1.1.0 to input 1.1.1

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@maryamhonari maryamhonari requested a review from hvpeteet November 5, 2021 15:42
hvpeteet
hvpeteet approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@hvpeteet hvpeteet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Maryam

@maryamhonari maryamhonari merged commit 04653e8 into 2.0-verified Nov 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the r2.0.1_fix_input_test branch November 5, 2021 16:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hvpeteet hvpeteet hvpeteet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryamhonari @hvpeteet