Skip to content

Fix for validate release links script #5100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2021
Merged

Fix for validate release links script #5100

merged 1 commit into from
Mar 15, 2021

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Mar 12, 2021

Proposed change(s)

Fixes two minor issues with the validate_release_links script.

  • Don't try to replace when there is no pip install line
  • Match Python versions with more than one digit per number (e.g. X.YY.Z).

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested a review from chriselion March 12, 2021 16:16
@ervteng ervteng mentioned this pull request Mar 12, 2021
Merged
10 tasks
chriselion
chriselion approved these changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that!

@ervteng ervteng merged commit 2073807 into main Mar 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surfnerd surfnerd surfnerd approved these changes

@chriselion chriselion chriselion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ervteng @surfnerd @chriselion