Skip to content

Switching to linux for proto gen, fix output paths #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2021
Merged

Switching to linux for proto gen, fix output paths #4831

merged 2 commits into from
Jan 7, 2021

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Jan 7, 2021 •
edited
Loading

Proposed change(s)

  • Change to linux image
  • Fix artifact paths - previously, we'd enter protobuf-definitions but not leave it before creating the artifacts/ directory, so the yamato job would be looking in the wrong place for it.

@chriselion chriselion mentioned this pull request Jan 7, 2021
Merged
surfnerd
surfnerd approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@surfnerd surfnerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@chriselion chriselion merged commit eea679d into master Jan 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the yamato-proto-patch branch January 7, 2021 18:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surfnerd surfnerd surfnerd approved these changes

@awjuliani awjuliani awjuliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriselion @surfnerd @awjuliani