Skip to content

[WIP] Integrate BrainParameters with ActionSpec, update BrainParametersDrawer #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dongruoping
Copy link
Contributor

Proposed change(s)

  • Add an ActionSpec in BrainParameters, replace old fields in BrainParameters with corresponding fields in ActionSpec and deprecate the old fields
  • Add serialization callbacks to propagate ActionSpec fields from the old fields
  • Update BrainParametersDrawer to allow specifying hybrid actions in editor
  • ActionSpec is modified to be not read-only

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

JIRA: MLA-1320

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@dongruoping dongruoping changed the base branch from develop-hybrid-actions-csharp to develop-hybrid-action-staging December 3, 2020 21:29
@dongruoping dongruoping changed the base branch from develop-hybrid-action-staging to develop-hybrid-actions-csharp December 3, 2020 22:25
@delete-merged-branch delete-merged-branch bot deleted the branch develop-hybrid-actions-csharp December 4, 2020 23:50
@dongruoping
Copy link
Contributor Author

closing this and replacing with #4718.

@dongruoping dongruoping closed this Dec 8, 2020
@dongruoping dongruoping deleted the develop-hybrid-brainparameters branch December 8, 2020 00:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant