Skip to content

Add useVectorFrozenFlag option in FoodCollector #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2020
Merged

Add useVectorFrozenFlag option in FoodCollector #4552

merged 1 commit into from
Oct 9, 2020
+17 −5

Conversation

dongruoping
Copy link
Contributor

Proposed change(s)

Bring back useVectorFrozenFlag option that was originally proposed in #4511 , since adding it as default will cause GridFoodCollector to crash.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion
Copy link
Contributor

Why does it break GridCollector? Just because the observation size changes?

@dongruoping
Copy link
Contributor Author

Why does it break GridCollector? Just because the observation size changes?

Yes right.

@dongruoping dongruoping merged commit 40f102e into release_8_branch Oct 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the r8-fix-gridfood branch October 9, 2020 17:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

1 more reviewer

@chriselion chriselion chriselion approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dongruoping @chriselion