Skip to content

More gail visual steps in simple test #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2020
Merged

More gail visual steps in simple test #3836

merged 3 commits into from
Apr 23, 2020

Conversation

andrewcoh
Copy link
Contributor

@andrewcoh andrewcoh commented Apr 23, 2020 •
edited
Loading

Proposed change(s)

Fixing the failing test in #3830

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@andrewcoh andrewcoh requested a review from chriselion April 23, 2020 22:13
chriselion
chriselion approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it passes.

@chriselion chriselion merged commit 09e8ea9 into support-newer-tensorflow Apr 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the more-gail-vis-steps branch April 23, 2020 23:41
chriselion pushed a commit that referenced this pull request Apr 24, 2020
@andrewcoh
support newer versions of tensorflow (2.1+) (#3830)
16f7bdb 
* support tf2.x and python3.8

* tensorflow==2.2.0rc3 for python3.8

* stick with tf2.1 and py3.7 for now

* More gail visual steps in simple test (#3836)

* increase gail visual ppo steps

* increase to 2000

* tune steps down to 750

Co-authored-by: andrewcoh <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@chriselion chriselion chriselion approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewcoh @chriselion