clean up migration notes #3313
Merged
clean up migration notes #3313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/Migrating.md
Outdated
| * Several changes were made to how agents are reset and marked as done: | ||
| * Calling `Done()` on the Agent will now reset it immediately and call the `AgentReset` virtual method. (This is to simplify the previous logic in which the Agent had to wait for the next `EnvironmentStep` to reset) | ||
| * The "Reset on Done" setting in AgentParameters was removed; this is now effectively always true. `AgentOnDone` virtual method on the Agent has been removed. | ||
| * Agents will always request a decision after being marked as `Done()` and will no longer wait for the next call to `RequestDecision()`. |
There was a problem hiding this comment.
Is this true ? I don't think that is right, if it is, it might be a bug.
There was a problem hiding this comment.
You wrote it :P I just moved it. I think it was from the first set of changes.
There was a problem hiding this comment.
That line came from #3242
surfnerd
approved these changes
Jan 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes to the migration docs, grouping the Agent reset/done notes together. Also added a note about Add/SetReward before Done.