Skip to content

queue type cleanup #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2020
Merged

queue type cleanup #3152

merged 1 commit into from
Jan 3, 2020

Conversation

chriselion
Copy link
Contributor

No description provided.

@chriselion chriselion requested a review from ervteng January 3, 2020 17:51
@@ -178,16 +181,16 @@ def __init__(self, behavior_id: str = None):
Initializes an AgentManagerQueue. Note that we can give it a behavior_id so that it can be identified
separately from an AgentManager.
"""
self.queue: Deque[Union[Trajectory, Policy]] = deque()
self.queue: Deque[T] = deque()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is what you were going for with the Union, this makes it a bit more general

Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ervteng ervteng merged commit 9272df6 into develop-queue Jan 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-queue-type-cleanup branch January 3, 2020 18:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants