Move getting srcClassName inside ReadAction in plugin #729 #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volivan239
force-pushed
the
volivan239/fix_exceptions_falling_for_kotlin_code
branch
from
4581bef to
916564e
Compare
Vassiliy-Kudryashov
approved these changes
Sep 14, 2022
volivan239
deleted the
volivan239/fix_exceptions_falling_for_kotlin_code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved call to PsiClass.name inside ReadAction block in plugin, so that
java.lang.Throwable: Read access is allowed from event dispatch thread or inside read-action onlyis not thrown anymore.Fixes #729
Type of Change
How Has This Been Tested?
Manual Scenario
Launch plugin on any Kotlin code -- the exception is not thrown anymore.
Checklist (remove irrelevant options):
This is the author self-check list