Add support for nullable fields in deep equals #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofurihafe
force-pushed
the
andrey-t/deep-equals-upgrade
branch
3 times, most recently
from
433567d to
8e8c0a4
Compare
EgorkaKulikov
approved these changes
Aug 25, 2022
sofurihafe
force-pushed
the
andrey-t/deep-equals-upgrade
branch
from
8e8c0a4 to
e263aaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, there was a test (PR) that was added in order to improve current deepequals implementation.
This PR improves current deepequals implementation.
When generating parametrized tests, we wrap field access in null check in order to make a generic execution more common for every execution. So, if there is a class with a nullable field, which has a field as well, as a result, in one execution we try to access the field's field, in another we assert it to be null. And we choose only one generic execution which is impossible in this case.
Fixes # (767)
Type of Change
How Has This Been Tested?
Automated Testing
Run utbot-samples with enabled parametrized test generation.
Manual Scenario
testClassWithNullableFieldtest,