Skip to content

additional message/notification/text display handling and other minor bug and formatting fixes#24

Merged
cristinamullin merged 16 commits intomainfrom
update-kw
Jan 29, 2026
Merged

additional message/notification/text display handling and other minor bug and formatting fixes#24
cristinamullin merged 16 commits intomainfrom
update-kw

Conversation

@wokenny13
Copy link
Copy Markdown
Collaborator

@wokenny13 wokenny13 commented Jan 27, 2026

Incorporates some draft TADACommunityHub validation function in the 2nd tab for summary output text.

Other text/notfication/message handling. For example, a warning notification will now be displayed indefinitely if the final loaded criteria table contains 0 rows (Ex. a user tries to upload the table output directly from Option C or D that has no additional values filled out). This message will stay up until a user supplies a loaded criteria table in the final step that has values to analyze, otherwise users cannot proceed.

Use TADA_CorrectColType() when necessary to ensure proper column type matches consistent with TADA workflows.

Handling of EquationBased column if a user does not fill that column out but has filled it other columns in the criteria and methodology table.

Some formatting consideration and minor bug crash handling in the app when going through different options of generating a criteria table in the 2nd tab.

include TADA_CorrectColType() to fix mismatch col type

edit message outputs in 2nd tab (still in draft)
notification_id will display a message and stay up if the final loaded criteria table has 0 rows for analysis.

It will stay up indefinitely until a final loaded criteria table is provided with at least 1 row.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2026

coverage-report

File Coverage Missing
All files 0%
R/app_config.R 0% 12-43
R/app_server.R 0% 13-64
R/app_ui.R 0% 27-115
R/fct_helpers.R 0% 15-1882
R/golem_utils_server.R 0% 21-63
R/golem_utils_ui.R 0% 13-367
R/mod_analysis_data_viewer_custom.R 0% 11-45
R/mod_analysis_data_viewer.R 0% 11-93
R/mod_analysis_plots.R 0% 11-752
R/mod_analysis_selector_custom.R 0% 12-249
R/mod_analysis_selector.R 0% 12-245
R/mod_batch_analysis.R 0% 13-839
R/mod_criteria_table.R 0% 14-823
R/mod_custom_analysis.R 0% 12-750
R/mod_excursion_viewer.R 0% 11-62
R/mod_load_file.R 0% 14-642
R/mod_map_table_selector_custom.R 0% 11-300
R/mod_map_table_selector.R 0% 11-301
R/mod_TADA_summary.R 0% 11-79
R/run_app.R 0% 19-31

Minimum allowed coverage is 10%

Generated by 🐒 cobertura-action against 6b3aba3

closest() is not a normal, exported function from dplyr. Add as global variable
@cristinamullin cristinamullin merged commit cde7c10 into main Jan 29, 2026
7 checks passed
@cristinamullin cristinamullin deleted the update-kw branch January 29, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants