additional message/notification/text display handling and other minor bug and formatting fixes#24
Merged
cristinamullin merged 16 commits intomainfrom Jan 29, 2026
Merged
additional message/notification/text display handling and other minor bug and formatting fixes#24cristinamullin merged 16 commits intomainfrom
cristinamullin merged 16 commits intomainfrom
Conversation
include TADA_CorrectColType() to fix mismatch col type edit message outputs in 2nd tab (still in draft)
notification_id will display a message and stay up if the final loaded criteria table has 0 rows for analysis. It will stay up indefinitely until a final loaded criteria table is provided with at least 1 row.
fix dependencies and description
|
coverage-report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6b3aba3 |
closest() is not a normal, exported function from dplyr. Add as global variable
cristinamullin
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates some draft TADACommunityHub validation function in the 2nd tab for summary output text.
Other text/notfication/message handling. For example, a warning notification will now be displayed indefinitely if the final loaded criteria table contains 0 rows (Ex. a user tries to upload the table output directly from Option C or D that has no additional values filled out). This message will stay up until a user supplies a loaded criteria table in the final step that has values to analyze, otherwise users cannot proceed.
Use TADA_CorrectColType() when necessary to ensure proper column type matches consistent with TADA workflows.
Handling of EquationBased column if a user does not fill that column out but has filled it other columns in the criteria and methodology table.
Some formatting consideration and minor bug crash handling in the app when going through different options of generating a criteria table in the 2nd tab.