app qa review (with new tab 2)

[sheilasaia]

Testing app at: https://tetratech-wtr-wne.shinyapps.io/TADAShinyAnalyze-Test/ with Montana dataset.

Comments:

• Upon first time loading the webpage, the app took ~5 seconds to load - I'm not sure there's much we can do there, but wanted to note that.
• tab 1: Write out ML as "monitoring locations (MLs)" the first time it's used under "Instructions"
• tab 1: Write out AU as "assessment unit (AU)" the first time it's used under "Instructions"
• tab 1: The statement at the top "Three files are necessary and must be uploaded to proceed." contradicts a little bit with the statement at the end "Users need to at least upload the water quality data...". Maybe delete the first sentence to avoid confusion?
• tab 1: What do you think about changing the last statement to: "If the tables in Steps 1b or 1c are not available, user will not be able to match the ATTAINS AU identifier or ATTAINS use name, respectively, for use in their batch and custom tab analysis." I think it's more than just use name that matters and it's important to say that without that data, tab 3 and 4 functionality will be more limited.
• tab 2: I'm not sure what the "Print all unique TADA.ComparableDataIdentifier in the criteria table" toggle is meant to do. When I toggle it on, nothing is printed out. Is that expected? I'm also seeing that for other options it doesn't seem to be adjusting anything in the printed-out message. Maybe a tool tip or brief explanation would be helpful?
• tab 2: When I select Option A (after refreshing the app and re-uploading files) and then select Montana. That seems to be working ok and makes sense to me. The template is generated but I get a warning message saying the user supplied criteriaMethods file is missing 33 unique TADA.ComparableIdentifiers and then lists those. This might be a little confusing because I didn't upload a criteriaMethods file for this option. Is that expected behavior? Maybe the file on the Community Hub has some issues and that's why I'm seeing this warning?
• tab 2: When I select Option B it maintains the select menu, but it's not populated with anything. Is that expected? Maybe it's best to remove the selection bar. I'm still able to generate the template but get a warning "TADA_ParametersForAnalysis: One or more organization identifiers entered by user is not found in ATTAINS." Output looks like it's from Blackfeet Tribe, but I don't need that info (all updates from tab 1 are for MTDEQ). Is this option meant to pull from the org id's in the files from tab 1? I think there might be something up with the selector bar but I'm not sure.
• tab 2: Option C and Option D look to have the same functionality on the UI side and I like that the selector bar is gone when I select those, but I see that the outputs are different (which is expected). No issues there!
• tab 2: When I select Option E and upload "Criteria_Methods_Template.xlsx", and then generate the template, I get a warning message which is helpful. It says that criteriaMethods file is missing 33 unique TADA.ComparableIdentifiers and then lists those.
• tab 2: For Option E is the downloaded template the same as the uploaded one? Would it be better to grey out the download template box for this option or am I misunderstanding something?
• tab 2: I tried a handful of times and the app seems to be working fine, but when I go to upload the criteria template ("Criteria_Methods_Template_edit.xlsx") at the bottom of tab 2 the server disconnects and asks me to reload and I'm not able to continue onto the other tabs. I pulled the latest version of dev2 and tried to run it and it's working ok locally so sounds like it might be a server thing. Maybe not enough memory? I think you may have to check the shinyapp.io logs for this one.
• tab 3 and 4: I like that it has the criteria method label at the top of the tab now. so you can remember what you selected on tab 2. I will note that it's possible for me to skip selection of the five options and upload the file. In that case, I haven't formally selected any option and Option A shows up because it was selected on tab 2 as the default. I'm not sure if this matters later in the later tabs, but wanted to make sure you were aware of this functionality. Is there a way to only allow the file upload on tab 2, once the user has selected an option and generated the table? And if the user doesn't want to select an option A-E, maybe there needs to be an option F that skips to upload or something like that? It might be good to ask Kenny and Cristina about that.
• tab 3 and 4: I have to select "No" for "Join the criteria table with fraction information" because the tool could not find match parameters, but it looks like there are different fractions in the water quality dataset. I'm not sure how to modify the criteria table to do this, but it might be good to test this functionality with a criteriaMethod table that has fractions to make sure it's doing what we want it to do.
• tab 4: If I select (1) analyze by AU, (2) all uses, (3) no for fraction info, (4) all sites, and (5) aluminum to run the custom analysis, the summary table has 6 results. By parameter map with aluminum and aquatic life has a median value of 11 and a max value of 8280, but if I look at the summary table, these refer to different rows. Meaning the median is pulled from one row and the max is pulled from a different row. It's possible that I'm not sure how the EPA and states determines what fraction and acute/chronic value to use, but that is a little confusing to me when I look between the map and table.

I think everything else seems to be functioning as I'd expect so I'll leave this review there.

Pinging @ycwwang and @KateriSalk.

[ycwwang]

I went though all these comments. I have updated the texts in the UI.

All the behavior in Tab 2 are as expected.

I removed the max and median from the popup of the summary map for simlicity and consistency.

[sheilasaia]

Update as of 2026-01-16: Yu-Chen addressed all major functionality issues but leaving this open in the parking lot because it also includes some future ideas for improvement.