app qa review feedback and areas for future development

[sheilasaia]

I used TADAShinyAnalyze app on shinyapps.io app version as of 2026-01-07).

(Test Case 1)
Selection
dates: 2024-01-01 to 2024-12-31
state: CO
Tribe data layers: "American Indian Reservations"
Tribal community: "Southern Ute Indian Tribe of the Southern Ute Reservation, CO"

Load Tab

• What do you think about writing something on the "Load Files" tab that says something along the lines of "If you don't upload an AU crosswalk and you're running this analysis for a Tribe, you will only be able to do batch and custom analyses by monitoring location id?" Or maybe that is redundant?
• I like how the file explorer only shows the file type you selected. Nice job!

Batch Tab

• When I tried to run the Southern Ute Tribe on the "Batch" tab with "Join the criteria table with fraction information" set to "Yes", I got a message after clicking on "Run Batch Analysis" that said "No data available after processing. Please check your input criteria." but the summary of the data box said there was 4 parameters that matched. I'm not sure why the batch analysis couldn't be run, but it might be helpful to have a tool tip below the "Join the criteria table with fraction" option to explain what this is doing a little bit more. Run button did work when I selected "No".
• I think on the top section of the "Batch" tab above the map section, we could make the right column a little wider. There's a lot of white space on the right side, currently.
• No suggestion from me here. THe "Choose sies to review the results" section is very cool! I really like the connected map and table functionality. Nice job!
• If the concentration vs time plot only has one red solid line, this means that it only has an upper limit with an "other" criteria source, correct? I think that legend makes sense to me but was curious if there's a way to remove the criteria source and limit type legend values when those aren't present for a specific parameter. Maybe you have to reset the levels in the filtered dataset so the plot shows the levels for the filtered dataset and not the levels for the whole dataset?
• Otherwise, these plots are awesome! I like the ability to add sites and select parameters, etc. of interest.

Custom Tab

• See my comment above under the batch tab, but on this tab, when I select "Yes" under "Join the criteria table with fraction information" I'm not getting an error like I did with the batch tab.
• I'm sorry if I missed a meeting on this, but where is the number for the standard coming from? Maybe it's worth adding a tool tip or sentence with a little more information under the summary table here and on the batch analysis tab. The results for me are looking the same for exceedances vs excursions. Maybe a future iteration could include the standard parameter value as a column in the analysis output summary table? If this is something the user would know, then please ignore my comment.
• Not a suggestion - just saying that the summary maps are very cool! The tabs turned out so good. Plots are also really great. I like that the user can download the plots.
• I did a quick check between the results of the filtered batch analysis and custom analysis when the same information is selected. Confirming that for at least one example, I'm getting the same results!

(Test Case 2)
Selection
dates: 2025-01-01 to 2025-05-31
state: SD

• I didn't have any issues with this dataset but did find that for a larger dataset, if you select sites in the dropdown too fast, the app may disconnect. I don't think there's anything we can do to fix this (unless we can increase the memory allocated to each user instance?), but it's worth telling users directly when the work on that app that it may take some time to load.

(Test Case 3)
Selection
Used the WY dataset in the shared drive that has an ML to AU table and AU to uses table.

• I didn't run into any big issues here, but I was a little confused about the resulting spatial data on the summary maps section is defined when the user selects the custom grouping option. For example, I chose two points (USGS-06277500 and USGS-06274300) and the output table seems to group them properly, but their is only one GPS point shown on the map (rather than two). I understand this point might be trying to represent the merged AU but some information is lost by dropping one of the points. Is there a way to use a convex hull or something to show the combined area of the GPS points. I'm fully aware this might be a future feature idea so no pressure to fix that now!
• I also noticed that sometimes the points on the summary map are sized differently for the different parameters, does the diameter of the point represent something? If so, I think we should include that in a legend on the map.
• All in all, I really like all the custom tab options! They seem very helpful and powerful.

[ycwwang]

Thanks for the review. The improvement of UI, such as summary plots and maps, could be future work.

[sheilasaia]

I'm going to reopen and put in the "parking lot" so we don't lose some of the notes for future development.