refactor(coverage): improve coverage inside lifecycle hooks #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omargallob
force-pushed
the
feat/omgallob/improve-coverage
branch
from
dcb2d83 to
acd1cc5
Compare
omargallob
changed the title
The src/ fallback is already handled in runner.sh after auto-discovery. Having it in both places is redundant since runner.sh calls init() after setting BASHUNIT_COVERAGE_PATHS.
The complex trap was: - Redundant: record_line already calls should_track internally - Semantically incorrect: used LINENO from frame 0 with BASH_SOURCE[1] - Adding overhead: extra function call on every line executed Revert to simple, efficient trap.
- Add SC2034 disable for environment variables used by bashunit - Use explicit BASHUNIT_COVERAGE_PATHS="src/" instead of relying on fallback
Chemaclass
added a commit
that referenced
this pull request
Dec 29, 2025
The coverage tracking in lifecycle hooks feature causes parallel test runs to hang indefinitely in GitHub Actions CI. This reverts all changes from PR #574 until the root cause of the parallel test hangs can be identified and fixed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Chemaclass
added a commit
to omargallob/bashunit
that referenced
this pull request
Dec 29, 2025
test runs to hang indefinitely in GitHub Actions CI. This reverts all changes from PR TypedDevs#574 until the root cause of the parallel test hangs can be identified and fixed.
Chemaclass
force-pushed
the
feat/omgallob/improve-coverage
branch
3 times, most recently
from
2521779 to
3d8b8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Enable coverage tracking inside lifecycle hooks (set_up, tear_down, set_up_before_script, tear_down_after_script) so that code executed during test setup/teardown is properly attributed in coverage reports.
🔖 Changes
execute_file_hookandexecute_test_hookin runner.shsrc/when auto-discovery yields no coverage pathsshould_trackcalls✅ To-do list
CHANGELOG.mdto reflect the new feature or fix