fix(client): add forward ip support in PTR query-name #1261
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwiN
requested changes
Sep 15, 2025
Owner
TwiN
left a comment
TwiN
left a comment
There was a problem hiding this comment.
Looks like you replaced all alignment from tabs to spaces. Can you revert that change?
Contributor
Author
Apologies, converted them back to tabs. |
TwiN
requested changes
Sep 15, 2025
TwiN
changed the title
TwiN
changed the title
TwiN
added
bug
Contributor
Author
|
Thanks, yeah had to look at the tests to figure out how to configure PTR and thought this would make the most sense. |
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Sep 18, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.23.2` -> `v5.24.0` | --- ### Release Notes <details> <summary>TwiN/gatus (ghcr.io/twin/gatus)</summary> ### [`v5.24.0`](https://github.com/TwiN/gatus/releases/tag/v5.24.0) [Compare Source](TwiN/gatus@v5.23.2...v5.24.0) Another big update worthy of highlights. There are 3 big changes coming to Gatus with this release. - **Suites** (ALPHA): To keep it short, this allows you to monitor a list of endpoints in order, but those endpoints have a shared context that allows you to store values and compare or use them in other endpoints. For more information, see <TwiN/gatus#1241> - **New alerting providers**: 14 new alerting providers have been added, but there's a catch. I don't have time to test this many providers, so I'm trying something new, namely, letting users who want to use those alerting providers test them for me. For more information, see <TwiN/gatus#1223> - **RDAP support for `[DOMAIN_EXPIRATION]` placeholder**: Some TLDs have started dropping support for WHOIS, as such, support for RDAP has been added. WHOIS will still be used as a fallback if RDAP fails to resolve the domain expiration of a domain. I am very excited to finally have made some progress on suites. It's missing some features, and it required a lot of redesigning, so I expect some complaints, but with suites, the possibilities feel endless. You can monitor entire workflows, simulate complex user behavior, not just READ-type of behavior, but WRITE as well, as you can configure an endpoint to run even if the workflow fails to clean up whatever resource you created, and so much more. Suites have some serious potential. #### What's Changed - feat(suite): Implement Suites by [@​TwiN](https://github.com/TwiN) in [#​1239](TwiN/gatus#1239) - feat(alerting): Add new providers for Datadog, IFTTT, Line, NewRelic, Plivo, RocketChat, SendGrid, Signal, SIGNL4, Splunk, Squadcast, Vonage, Webex and Zapier by [@​TwiN](https://github.com/TwiN) in [#​1224](TwiN/gatus#1224) - feat(client): Add RDAP support for domain expiration by [@​ju-ef](https://github.com/ju-ef) in [#​1181](TwiN/gatus#1181) - feat(client): starttls support for dns resolver by [@​eleith](https://github.com/eleith) in [#​1253](TwiN/gatus#1253) - fix(alerting): Adjust minimum reminder config parsing by [@​xconverge](https://github.com/xconverge) in [#​1226](TwiN/gatus#1226) - fix(client): add forward ip support in PTR query-name by [@​denis-ev](https://github.com/denis-ev) in [#​1261](TwiN/gatus#1261) - docs: Fix typo in Zulip configuration section by [@​XavierDupuis](https://github.com/XavierDupuis) in [#​1220](TwiN/gatus#1220) - docs: information on escaping endpoint url in config by [@​muzy](https://github.com/muzy) in [#​1242](TwiN/gatus#1242) #### New Contributors - [@​XavierDupuis](https://github.com/XavierDupuis) made their first contribution in [#​1220](TwiN/gatus#1220) - [@​eleith](https://github.com/eleith) made their first contribution in [#​1253](TwiN/gatus#1253) - [@​ju-ef](https://github.com/ju-ef) made their first contribution in [#​1181](TwiN/gatus#1181) - [@​denis-ev](https://github.com/denis-ev) made their first contribution in [#​1261](TwiN/gatus#1261) - [@​muzy](https://github.com/muzy) made their first contribution in [#​1242](TwiN/gatus#1242) **Full Changelog**: <TwiN/gatus@v5.23.2...v5.24.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMTYuNSIsInVwZGF0ZWRJblZlciI6IjQxLjExNi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbWFnZSJdfQ==--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1491 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added forward IP support to PTR record, with backwards compatibility
if no in-addr.arpa. is found, the ip will be treated as plain ip and the suffix is added
reduces the risk of typos when adding IP and makes it a lot more user friendly
Checklist
README.md, if applicable.