-
Notifications
You must be signed in to change notification settings - Fork 8
CompatHelper: bump compat for Turing to 0.40, (keep existing compat) #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for Turing to 0.40, (keep existing compat) #173
Conversation
d67c80f
to
3fca127
Compare
TuringGLM.jl documentation for PR #173 is available at: |
Pull Request Test Coverage Report for Build 16993043643Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This is really strange, why the LTS CI is giving wrong estimates when compared to the latest Julia? |
Changed the compat bound to 0.20-0.40 |
It's only off by a bit, so I think it's just an unfortunate seed. In general the PRNGs in julia> # 1.11
randn(Xoshiro(468), 10000)[4502]
-3.6670359282971967
julia> # 1.10
randn(Xoshiro(468), 10000)[4502]
-3.6557814790472025 The solution to this is to use StableRNGs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2e8a78b
Thanks! Too bad one seed had to be incremented
Feel free to merge once CI passes, and tag a new version. |
This pull request changes the compat entry for the
Turing
package from0.20 - 0.39
to0.20 - 0.39, 0.40
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.