Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Turing package from 0.20 - 0.39 to 0.20 - 0.39, 0.40.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@storopoli storopoli force-pushed the compathelper/new_version/2025-08-15-00-15-52-386-04049422093 branch from d67c80f to 3fca127 Compare August 15, 2025 00:15
Copy link
Contributor Author

TuringGLM.jl documentation for PR #173 is available at:
https://TuringLang.github.io/TuringGLM.jl/previews/PR173/

@coveralls
Copy link

coveralls commented Aug 15, 2025

Pull Request Test Coverage Report for Build 16993043643

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.566%

Totals Coverage Status
Change from base Build 16908503471: 0.0%
Covered Lines: 187
Relevant Lines: 265

💛 - Coveralls

@storopoli
Copy link
Member

This is really strange, why the LTS CI is giving wrong estimates when compared to the latest Julia?
@penelopeysm can you please take a look when you get the chance?

@storopoli
Copy link
Member

Changed the compat bound to 0.20-0.40

@storopoli storopoli added the dependencies Pull requests that update a dependency file label Aug 15, 2025
@penelopeysm
Copy link
Member

why the LTS CI is giving wrong estimates when compared to the latest Julia?

It's only off by a bit, so I think it's just an unfortunate seed. In general the PRNGs in Random.default_rng() are not guaranteed to give reproducible results across Julia versions (https://docs.julialang.org/en/v1/stdlib/Random/#Reproducibility), so for example:

julia> # 1.11
       randn(Xoshiro(468), 10000)[4502]
-3.6670359282971967

julia> # 1.10
       randn(Xoshiro(468), 10000)[4502]
-3.6557814790472025

The solution to this is to use StableRNGs.

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2e8a78b
Thanks! Too bad one seed had to be incremented

@storopoli
Copy link
Member

Feel free to merge once CI passes, and tag a new version.

@penelopeysm penelopeysm merged commit b25f218 into main Aug 15, 2025
11 checks passed
@penelopeysm penelopeysm deleted the compathelper/new_version/2025-08-15-00-15-52-386-04049422093 branch August 15, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants