Skip to content

Bugfix in running TapedFunction. #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2022
Merged

Bugfix in running TapedFunction. #135

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b58ca3
Bugfix in running TapedFunction.
yebai Mar 25, 2022
cb729b9
don't rest counter in tapedtask
KDr2 Mar 25, 2022
8cd38a2
Apply suggestions from code review
yebai Mar 26, 2022
cd179d1
Apply suggestions from code review
yebai Mar 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/tapedfunction.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,12 @@ end
@inline val(x::TapedFunction) = x.func
@inline result(t::TapedFunction) = t.bindings[t.retval]

function (tf::TapedFunction)(args...; callback=nothing)
function (tf::TapedFunction)(args...; callback=nothing, continue=false)
if !continue # reset counter and retval to run from the start
tf.counter = 1;
tf.retval = :none;
end

# set args
if tf.counter <= 1
haskey(tf.bindings, :_1) && _update_var!(tf, :_1, tf.func)
Expand Down
2 changes: 1 addition & 1 deletion src/tapedtask.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ end

function wrap_task(tf, produce_ch, consume_ch, args...)
try
tf(args...; callback=producer)
tf(args...; callback=producer, continue=true)
catch e
bt = catch_backtrace()
put!(produce_ch, TapedTaskException(e, bt))
Expand Down