Skip to content

Benchmark produce #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 29, 2022
Merged

Benchmark produce #134

merged 7 commits into from
Mar 29, 2022

Conversation

yebai
Copy link
Member

@yebai yebai commented Mar 25, 2022

No description provided.

@yebai yebai force-pushed the master branch 2 times, most recently from da20c94 to f4e64d5 Compare March 25, 2022 19:12
@KDr2 KDr2 closed this Mar 28, 2022
@KDr2 KDr2 deleted the benchmark branch March 28, 2022 00:32
@KDr2 KDr2 restored the benchmark branch March 28, 2022 00:33
@KDr2 KDr2 reopened this Mar 28, 2022
Copy link
Contributor

@rikhuijzer rikhuijzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few suggestions to make the code more idiomatic. On top of that, the code contains a lot of semicolons at line endings. Would be good to remove those too

@yebai
Copy link
Member Author

yebai commented Mar 28, 2022

I've added a few suggestions to make the code more idiomatic. On top of that, the code contains a lot of semicolons at line endings. Would be good to remove those too

thanks @rikhuijzer - this PR contains a lot of code copy-and-pasted from terminals when I was debugging #135, which is a bit messy.

@yebai yebai requested a review from KDr2 March 28, 2022 13:57
@rikhuijzer
Copy link
Contributor

In general, I like this PR by the way a lot. I had a lot of trouble debugging the functionality when I was working on Libtask. One question: do you know how well these estimates represent the workload under normal load?

@yebai
Copy link
Member Author

yebai commented Mar 29, 2022

One question: do you know how well these estimates represent the workload under normal load?

These examples cover loops and produce calls, which I suspect are the bottlenecks for optimal performance. The former is very sensitive to type-instability, while the latter tests the efficiency of the most frequent TapedTask operation. The TArray stuff is potentially a bottleneck for performance, but they can be depreciated now since the new tape-based mechanism provides a more flexible solution for controlling which variables get copied.

@yebai yebai merged commit b389311 into master Mar 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the benchmark branch March 29, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants