-
Notifications
You must be signed in to change notification settings - Fork 10
Benchmark produce
#134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark produce
#134
Conversation
da20c94
to
f4e64d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few suggestions to make the code more idiomatic. On top of that, the code contains a lot of semicolons at line endings. Would be good to remove those too
Co-authored-by: Rik Huijzer <[email protected]>
thanks @rikhuijzer - this PR contains a lot of code copy-and-pasted from terminals when I was debugging #135, which is a bit messy. |
In general, I like this PR by the way a lot. I had a lot of trouble debugging the functionality when I was working on Libtask. One question: do you know how well these estimates represent the workload under normal load? |
These examples cover loops and produce calls, which I suspect are the bottlenecks for optimal performance. The former is very sensitive to type-instability, while the latter tests the efficiency of the most frequent |
No description provided.