Avoid method redefinition #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
+ Coverage 88.19% 88.24% +0.04%
==========================================
Files 9 9
Lines 720 723 +3
==========================================
+ Hits 635 638 +3
Misses 85 85
Continue to review full report at Codecov.
|
mohamed82008
reviewed
Mar 9, 2020
| @@ -588,9 +588,8 @@ function build_output(model_info) | |||
| end | |||
| end) | |||
| end | |||
| return esc(quote | |||
| # Allows passing arguments as kwargs | |||
| $outer_function(;$(args...)) = $outer_function($(arg_syms...)) | |||
There was a problem hiding this comment.
This is a feature of DPPL and Turing that we can pass only the second argument for example as a kwarg and the first is given its default value.
There was a problem hiding this comment.
This PR just checks if args is empty and does not add the duplicate definition in case it is. The function that allows to pass keyword arguments is defined below.
mohamed82008
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning in JuliaDebug/JuliaInterpreter.jl#380 seems to be related to https://github.com/TuringLang/Turing.jl/blob/7cd1800905d51e9cd4f2db5072b96a79e9c6c74f/src/core/compiler.jl#L404-L443.