Skip to content

Conversation

FredericWantiez
Copy link
Member

Change type signature and format from review in #23

@coveralls
Copy link

coveralls commented Sep 25, 2021

Pull Request Test Coverage Report for Build 1273091961

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 59.951%

Totals Coverage Status
Change from base Build 1234945261: 0.1%
Covered Lines: 247
Relevant Lines: 412

💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #31 (ec38abe) into master (51c18d4) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   59.85%   59.95%   +0.09%     
==========================================
  Files           6        6              
  Lines         411      412       +1     
==========================================
+ Hits          246      247       +1     
  Misses        165      165              
Impacted Files Coverage Δ
src/container.jl 92.41% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c18d4...ec38abe. Read the comment docs.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @FredericWantiez, looks good to me!

@yebai yebai merged commit 9f8522f into TuringLang:master Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants