Skip to content

Add Aqua tests and fix the issues found#1498

Merged
datejada merged 2 commits intomainfrom
aqua
Feb 24, 2026
Merged

Add Aqua tests and fix the issues found#1498
datejada merged 2 commits intomainfrom
aqua

Conversation

@abelsiqueira
Copy link
Copy Markdown
Member

@abelsiqueira abelsiqueira commented Feb 23, 2026

Adds Aqua.test_all from Aqua.jl.
Aqua.jl provides some quality checks, like wrong exports and type piracies.
This commit also fixes the issues found at the moment.

Related issues

Closes #1500

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

Adds Aqua.test_all from Aqua.jl.
Aqua.jl provides some quality checks, like wrong exports and type piracies.
This commit also fixes the issues found at the moment.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 23, 2026

🤖 CompareMPS report

✅ MPS files match

@github-actions
Copy link
Copy Markdown
Contributor

📝 Check the documentation preview: https://tulipaenergy.github.io/TulipaEnergyModel.jl/previews/PR1498

@abelsiqueira abelsiqueira marked this pull request as ready for review February 23, 2026 17:04
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.52%. Comparing base (f9b9c1e) to head (6498a58).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          42       41    -1     
  Lines        1624     1625    +1     
=======================================
+ Hits         1600     1601    +1     
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abelsiqueira abelsiqueira requested a review from gnawin February 23, 2026 18:58
Copy link
Copy Markdown
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abelsiqueira thanks for the PR, this is useful. My only comment is whether itis necessary to add a note or comment to the developer's documentation, or whether running Aqua within the tests is enough to provide the necessary info to fix the problems it finds.

@datejada
Copy link
Copy Markdown
Member

Also, is it worthy to add the badge? https://github.com/JuliaTesting/Aqua.jl?tab=readme-ov-file#badge
Thanks!

@abelsiqueira
Copy link
Copy Markdown
Member Author

@datejada, I've added some docs linking to Aqua docs, but there aren't any tips, AFAIK.
And indeed, I forgot the badge.

Copy link
Copy Markdown
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the update. LGTM 😄

@datejada datejada merged commit 6f34d69 into main Feb 24, 2026
9 checks passed
@datejada datejada deleted the aqua branch February 24, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test] Add Aqua to tests

2 participants