Conversation
Adds Aqua.test_all from Aqua.jl. Aqua.jl provides some quality checks, like wrong exports and type piracies. This commit also fixes the issues found at the moment.
🤖 CompareMPS report✅ MPS files match |
|
📝 Check the documentation preview: https://tulipaenergy.github.io/TulipaEnergyModel.jl/previews/PR1498 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 42 41 -1
Lines 1624 1625 +1
=======================================
+ Hits 1600 1601 +1
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
datejada
left a comment
There was a problem hiding this comment.
Hi @abelsiqueira thanks for the PR, this is useful. My only comment is whether itis necessary to add a note or comment to the developer's documentation, or whether running Aqua within the tests is enough to provide the necessary info to fix the problems it finds.
|
Also, is it worthy to add the badge? https://github.com/JuliaTesting/Aqua.jl?tab=readme-ov-file#badge |
|
@datejada, I've added some docs linking to Aqua docs, but there aren't any tips, AFAIK. |
datejada
left a comment
There was a problem hiding this comment.
Great! Thanks for the update. LGTM 😄
Adds Aqua.test_all from Aqua.jl.
Aqua.jl provides some quality checks, like wrong exports and type piracies.
This commit also fixes the issues found at the moment.
Related issues
Closes #1500
Checklist