Skip to content

🐛 Fixed contributor user menu Posts link navigating to wrong route#26716

Merged
kevinansfield merged 1 commit intomainfrom
ONC-1512-contributor-posts-link
Mar 5, 2026
Merged

🐛 Fixed contributor user menu Posts link navigating to wrong route#26716
kevinansfield merged 1 commit intomainfrom
ONC-1512-contributor-posts-link

Conversation

@kevinansfield
Copy link
Member

@kevinansfield kevinansfield commented Mar 5, 2026

ref https://linear.app/ghost/issue/ONC-1512/

  • Fixed the "Posts" link in the contributor user menu pointing to / instead of /posts, causing navigation to the wrong route

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 41e5be64-39da-4155-b771-c8dfa646186e

📥 Commits

Reviewing files that changed from the base of the PR and between 5807a2caa9f1bcab8ab27476bbdc987b1469da80 and 7f998cf.

📒 Files selected for processing (1)
  • apps/admin/src/layout/app-sidebar/user-menu.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/admin/src/layout/app-sidebar/user-menu.tsx

Walkthrough

The change modifies the navigation target of the first menu item in the ContributorUserMenu component within the user menu sidebar layout. The navigation path was updated from the root path "/" to "/posts". This is a straightforward routing modification affecting one menu item with no impact on other menu items or component behavior.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing a contributor user menu Posts link that was navigating to the wrong route.
Description check ✅ Passed The description is directly related to the changeset, explaining the bug fix with a reference to the issue tracker.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ONC-1512-contributor-posts-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ref https://linear.app/ghost/issue/ONC-1512/

The Posts link in the contributor user menu was pointing to `/` instead
of `/posts`, causing it to navigate to `/#/` instead of `/#/posts`.
@kevinansfield kevinansfield force-pushed the ONC-1512-contributor-posts-link branch from 5807a2c to 7f998cf Compare March 5, 2026 15:55
@kevinansfield kevinansfield enabled auto-merge (squash) March 5, 2026 15:56
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/admin/src/layout/app-sidebar/user-menu.tsx`:
- Line 225: The "Posts" nav Link currently uses an invalid absolute route
(`<Link to="/posts">`); update the Link in user-menu.tsx to use the relative
route pattern used in nav-content.tsx (e.g., set the Link target to
"posts?type=published") so it matches the mounted posts app routes, or if the
intent was to open tags change it to the valid `/tags` route; locate the JSX
Link element named "Posts" and replace its to prop accordingly (use the relative
"posts?type=published" to follow the existing pattern).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 26099c44-ef59-400a-bf34-1c8ab77604f7

📥 Commits

Reviewing files that changed from the base of the PR and between bc692dc and 5807a2caa9f1bcab8ab27476bbdc987b1469da80.

📒 Files selected for processing (2)
  • apps/admin/src/layout/admin-layout.tsx
  • apps/admin/src/layout/app-sidebar/user-menu.tsx

@kevinansfield kevinansfield merged commit ce9f28c into main Mar 5, 2026
29 checks passed
@kevinansfield kevinansfield deleted the ONC-1512-contributor-posts-link branch March 5, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant