🐛 Fixed contributor user menu Posts link navigating to wrong route#26716
🐛 Fixed contributor user menu Posts link navigating to wrong route#26716kevinansfield merged 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📥 CommitsReviewing files that changed from the base of the PR and between 5807a2caa9f1bcab8ab27476bbdc987b1469da80 and 7f998cf. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe change modifies the navigation target of the first menu item in the ContributorUserMenu component within the user menu sidebar layout. The navigation path was updated from the root path "/" to "/posts". This is a straightforward routing modification affecting one menu item with no impact on other menu items or component behavior. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ref https://linear.app/ghost/issue/ONC-1512/ The Posts link in the contributor user menu was pointing to `/` instead of `/posts`, causing it to navigate to `/#/` instead of `/#/posts`.
5807a2c to
7f998cf
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/admin/src/layout/app-sidebar/user-menu.tsx`:
- Line 225: The "Posts" nav Link currently uses an invalid absolute route
(`<Link to="/posts">`); update the Link in user-menu.tsx to use the relative
route pattern used in nav-content.tsx (e.g., set the Link target to
"posts?type=published") so it matches the mounted posts app routes, or if the
intent was to open tags change it to the valid `/tags` route; locate the JSX
Link element named "Posts" and replace its to prop accordingly (use the relative
"posts?type=published" to follow the existing pattern).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 26099c44-ef59-400a-bf34-1c8ab77604f7
📥 Commits
Reviewing files that changed from the base of the PR and between bc692dc and 5807a2caa9f1bcab8ab27476bbdc987b1469da80.
📒 Files selected for processing (2)
apps/admin/src/layout/admin-layout.tsxapps/admin/src/layout/app-sidebar/user-menu.tsx
ref https://linear.app/ghost/issue/ONC-1512/
/instead of/posts, causing navigation to the wrong route