Skip to content

🐛 Fixed contributor posts list not being scrollable#26715

Merged
kevinansfield merged 1 commit intomainfrom
ONC-1512-contributor-scroll
Mar 5, 2026
Merged

🐛 Fixed contributor posts list not being scrollable#26715
kevinansfield merged 1 commit intomainfrom
ONC-1512-contributor-scroll

Conversation

@kevinansfield
Copy link
Member

fixes https://linear.app/ghost/issue/ONC-1512/

The contributor layout used h-full overflow-auto on the <main> element, with the EmberRoot child also using h-full. This constrained the Ember content to exactly the scroll container's height, so .gh-viewport's overflow: hidden clipped the posts list with no way to scroll.

Changed the contributor layout to use the same flex column pattern as the non-contributor SidebarInset layout — a flex flex-col overflow-y-auto container with a flex-1 wrapper for children. This allows the content to grow beyond the container via min-height: auto, enabling scroll.

fixes https://linear.app/ghost/issue/ONC-1512/

The contributor layout used `h-full overflow-auto` on the main element
with children that also had `h-full`, constraining content to exactly
the viewport height. Changed to use a flex column pattern matching the
non-contributor SidebarInset layout so content can grow beyond the
scroll container.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9b3dfc8b-6187-46a5-a6b5-de7d120591bb

📥 Commits

Reviewing files that changed from the base of the PR and between 1e76657 and 71afaeb.

📒 Files selected for processing (1)
  • apps/admin/src/layout/admin-layout.tsx

Walkthrough

The main layout component was modified to adjust how content is rendered for a specific user category. The content area structure changed from using a full-height element with overflow auto to a vertical flex-based container with auto vertical overflow. The children content now wrap in a flex-1 element within this container. This modifies the internal layout flow and scrolling behavior while keeping the external interface consistent. The sidebar structure and provider configuration remain unchanged.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references fixing a scrolling issue for contributor posts, which directly matches the main change of modifying the AdminLayout's flex container structure to restore scrollable behavior.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem with the constrained layout and how the flex column pattern change fixes the scrolling issue for the contributor posts list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ONC-1512-contributor-scroll

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevinansfield kevinansfield enabled auto-merge (squash) March 5, 2026 15:24
@ErisDS
Copy link
Member

ErisDS commented Mar 5, 2026

🤖 Velo CI Failure Analysis

Classification: 🔴 HARD FAIL

  • Workflow: CI
  • Failed Step: Load Image
  • Run: View failed run
    What failed: Docker login to ghcr.io failed due to network timeout
    Why: The logs show a network error when trying to log in to the GitHub Container Registry (ghcr.io). This is an infrastructure issue outside the control of the code changes, and is likely due to a temporary network problem or rate limiting.
    Action:
    This is a transient infrastructure issue, so retrying the build may resolve the problem. If the issue persists, the maintainers should investigate the GitHub Actions runner configuration or contact GitHub support.

@kevinansfield kevinansfield merged commit 2195cb5 into main Mar 5, 2026
53 of 58 checks passed
@kevinansfield kevinansfield deleted the ONC-1512-contributor-scroll branch March 5, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants