🐛 Fixed contributor posts list not being scrollable#26715
Conversation
fixes https://linear.app/ghost/issue/ONC-1512/ The contributor layout used `h-full overflow-auto` on the main element with children that also had `h-full`, constraining content to exactly the viewport height. Changed to use a flex column pattern matching the non-contributor SidebarInset layout so content can grow beyond the scroll container.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe main layout component was modified to adjust how content is rendered for a specific user category. The content area structure changed from using a full-height element with overflow auto to a vertical flex-based container with auto vertical overflow. The children content now wrap in a flex-1 element within this container. This modifies the internal layout flow and scrolling behavior while keeping the external interface consistent. The sidebar structure and provider configuration remain unchanged. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Velo CI Failure AnalysisClassification: 🔴 HARD FAIL
|
fixes https://linear.app/ghost/issue/ONC-1512/
The contributor layout used
h-full overflow-autoon the<main>element, with the EmberRoot child also usingh-full. This constrained the Ember content to exactly the scroll container's height, so.gh-viewport'soverflow: hiddenclipped the posts list with no way to scroll.Changed the contributor layout to use the same flex column pattern as the non-contributor
SidebarInsetlayout — aflex flex-col overflow-y-autocontainer with aflex-1wrapper for children. This allows the content to grow beyond the container viamin-height: auto, enabling scroll.