Fixed label select ordering with infinite scroll

[kevinansfield]

Summary

• Removed ignorePunctuation: true from label client-side sort to match server ordering
• ignorePunctuation caused #-prefixed labels to sort as if the # didn't exist, but the server's name asc puts # before alphabetical characters
• This mismatch meant each new page of labels loaded via infinite scroll appeared in the wrong position instead of appending to the list

ref https://linear.app/ghost/issue/BER-3402/

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7d04cbbb-7bb7-4350-8cea-0f124fbc22cc

📥 Commits

Reviewing files that changed from the base of the PR and between 3671359 and 96a6cdc.

📒 Files selected for processing (1)

• ghost/admin/app/services/labels-manager.js

---

Walkthrough

The change modifies the label sorting logic by removing the ignorePunctuation: true parameter from a localeCompare call in the labels-manager service. This updates the sorting algorithm to respect punctuation characters that were previously ignored during alphabetical ordering. The modification affects how labels are ordered but does not alter any public API signatures.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing label ordering to work correctly with infinite scroll by removing the ignorePunctuation option.
Description check	✅ Passed	The description clearly explains the problem, solution, and impact: removing ignorePunctuation from client-side sorting to match server behavior and fix infinite scroll label positioning.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch worktree-BER-3402-label-select-ordering

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}