Added Swedish locale for Portal#24723
Conversation
WalkthroughThis change updates Swedish localization data in two files: ghost/i18n/locales/sv/comments.json and ghost/i18n/locales/sv/ghost.json. It fills previously empty values with Swedish translations, adds a few new translation keys (e.g., edited, Enter your name, Expertise), and refines some existing strings. Keys include UI labels, notifications, and email texts such as verification, comment notifications, and sorting options. No code logic, structure, or APIs are modified—only string values in JSON locale files are updated. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (14)
ghost/i18n/locales/sv/comments.json (7)
9-11: Polish phrasing; reflect the “invite to add background” intent for expertise
- The guidance sentence (Line 9) is a bit clunky; suggest a smoother, more idiomatic Swedish.
- “Add your expertise” (Line 11) is shown as a link inviting the user to share background. Keep the invitational tone (cf. past learnings).
Apply:
-"Add context to your comment, share your name and expertise to foster a healthy discussion.": "Lägg till kontext till din kommentar, som ditt namn, din expertis för att skapa ett bra forum.", +"Add context to your comment, share your name and expertise to foster a healthy discussion.": "Lägg till sammanhang i din kommentar – dela ditt namn och din expertis för att främja en bra diskussion.", -"Add your expertise": "Lägg till din expertis", +"Add your expertise": "Lägg till din expertis"Note: the second line keeps the same words but confirms the intent (invitation) is appropriate for the UI link. If you prefer, “Lägg till din bakgrund” is also natural in Swedish for this context.
16-16: Trim trailing whitespaceThere’s a trailing space at the end of the value.
-"Become a paid member of {publication} to start commenting.": "Bli betalande medlem på {publication} för att börja kommentera ", +"Become a paid member of {publication} to start commenting.": "Bli betalande medlem på {publication} för att börja kommentera",
34-34: Gender agreement: “Dold” (not “Dolt”)“Kommentar” is an en‑word; use “Dold för medlemmar”.
-"Hidden for members": "Dolt för medlemmar", +"Hidden for members": "Dold för medlemmar",
47-47: More idiomatic warning“Kommentar kan ej återskapas …” is stiff and missing article. Prefer “återställas”.
-"Once deleted, this comment can’t be recovered.": "Kommentar kan ej återskapas efter borttagning", +"Once deleted, this comment can’t be recovered.": "När den här kommentaren har raderats kan den inte återställas",
51-53: Prepositions: “Replied to”/“Reply to”
- “Svarade till” is unnatural; use “Svar till” (metadata).
- Imperative “Svara på” fits Swedish UI for replying to something.
-"Replied to": "Svarade till", +"Replied to": "Svar till", -"Reply to": "Svara till", +"Reply to": "Svara på",
63-63: Use “svar” instead of “kommentar” for replies-"Show 1 more reply": "Visa 1 kommentar till", +"Show 1 more reply": "Visa 1 svar till",
31-33: Optional: keep example names/brands semantically aligned
- “Founder @ Acme Inc” uses “@” meaning “at”; “Grundare av …” changes meaning to “of”. Suggest “på”.
- Localising names is fine; just flagging for consistency across locales.
-"Founder @ Acme Inc": "Grundare av Företaget AB", +"Founder @ Acme Inc": "Grundare på Företaget AB",Also applies to: 37-37
ghost/i18n/locales/sv/ghost.json (7)
17-17: Preposition and punctuation in security line
- Use “logga in på” (not “till”).
- Keep the trailing colon, as in source.
-"For security verification, enter the code below to sign in to {siteTitle}:": "Av säkerhetskäl behöver du ange koden nedan för att logga in till {siteTitle}", +"For security verification, enter the code below to sign in to {siteTitle}:": "Av säkerhetsskäl, ange koden nedan för att logga in på {siteTitle}:",
4-4: Add ending period for consistencySource has a period; most adjacent Swedish strings keep sentence punctuation.
-"Become a paid member of {site} to get access to all premium content.": "Bli betalande medlem på {site} för att få tillgång till allt innehåll", +"Become a paid member of {site} to get access to all premium content.": "Bli betalande medlem på {site} för att få tillgång till allt innehåll.",
32-33: “on {postTitle}” → “på {postTitle}”Use “på” for content hosted on a post/site.
-"New comment on {postTitle}": "Ny kommentar i {postTitle}", +"New comment on {postTitle}": "Ny kommentar på {postTitle}", -"New reply to your comment on {siteTitle}": "Nytt svar till din kommentar på {siteTitle}", +"New reply to your comment on {siteTitle}": "Nytt svar på din kommentar på {siteTitle}", -"Someone just replied to your comment on {postTitle}.": "Någon svarade just på din kommentar i {postTitle}.", +"Someone just replied to your comment on {postTitle}.": "Någon svarade just på din kommentar på {postTitle}.",Also applies to: 43-43
54-54: Natural Swedish for unsubscribe from reply notifications“Avböj notifikation …” is odd. Suggest “Avsluta aviseringar …” or “Avsluta notiser …”.
-"Unsubscribe from comment reply notifications": "Avböj notifikation vid svar på kommentar", +"Unsubscribe from comment reply notifications": "Avsluta aviseringar om svar på kommentarer",
57-57: Prefer “Visa” for UI actions“Se kommentarer” is understandable but “Visa kommentarer” is the standard UI verb.
-"View comments": "Se kommentarer", +"View comments": "Visa kommentarer",
65-66: Notification phrasing and tense
- “stänga av notifikationer” → “avanmäla/avsluta aviseringar” is more idiomatic.
- “You just tried …” should be past (“Du försökte nyss/precis …”), not present.
-"You can unsubscribe from these notifications at {profileUrl}.": "Du kan stänga av notifikationer på {profileUrl}.", +"You can unsubscribe from these notifications at {profileUrl}.": "Du kan avanmäla dessa aviseringar på {profileUrl}.", -"You just tried to access your account from a new device.": "Du försöker logga in på ditt konto från en ny enhet.", +"You just tried to access your account from a new device.": "Du försökte nyss komma åt ditt konto från en ny enhet.",
63-63: Optional: “subscriber” vs “medlem”Source uses “subscriber”; Swedish “prenumerant” is closer than “medlem”. Consider aligning if other locales follow that convention.
-"You are receiving this because you are a <strong>%%{status}%% subscriber</strong> to {site}.": "Du får det här eftersom du är en <strong>%%{status}%% medlem</strong> på {site}.", +"You are receiving this because you are a <strong>%%{status}%% subscriber</strong> to {site}.": "Du får det här eftersom du är <strong>%%{status}%% prenumerant</strong> på {site}.",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
ghost/i18n/locales/sv/comments.json(3 hunks)ghost/i18n/locales/sv/ghost.json(4 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: cathysarisky
PR: TryGhost/Ghost#0
File: :0-0
Timestamp: 2025-01-29T15:27:29.391Z
Learning: When reviewing translation files in ghost/i18n/locales, translators should only modify the translated values and must not change the keys or placeholder styles (e.g., %%{status}%%, {site}, etc.) as they serve specific purposes like Mailgun string replacement.
Learnt from: cathysarisky
PR: TryGhost/Ghost#0
File: :0-0
Timestamp: 2025-05-20T21:08:21.026Z
Learning: In the Ghost project, translation files (ghost/i18n/locales/*/*.json) commonly have blank values for translations, and this is normal behavior that should not be flagged in reviews. These empty translations will be filled in separate PRs.
Learnt from: cathysarisky
PR: TryGhost/Ghost#23070
File: ghost/i18n/locales/hu/comments.json:45-45
Timestamp: 2025-04-30T16:27:03.542Z
Learning: In the Ghost project, new translation string keys are intentionally added with empty values initially and will be translated in a separate PR. Do not report missing translations for entirely new string additions.
Learnt from: cathysarisky
PR: TryGhost/Ghost#22175
File: ghost/i18n/locales/pt-BR/portal.json:18-18
Timestamp: 2025-02-12T20:09:12.731Z
Learning: In the Ghost project, new translation keys are first added with empty string values, and the actual translations are added later in separate PRs to maintain better organization of translation work.
Learnt from: cathysarisky
PR: TryGhost/Ghost#22075
File: ghost/i18n/locales/pt-BR/portal.json:0-0
Timestamp: 2025-01-30T15:13:48.222Z
Learning: When reviewing translation files in i18n/locales/*, the keys (left side) must never be changed. If a translator has modified any keys, this should be flagged as a potential error requiring review or correction. Only the translation values (right side) should be modified.
📚 Learning: 2025-01-29T15:27:29.391Z
Learnt from: cathysarisky
PR: TryGhost/Ghost#0
File: :0-0
Timestamp: 2025-01-29T15:27:29.391Z
Learning: When reviewing translation files in ghost/i18n/locales, translators should only modify the translated values and must not change the keys or placeholder styles (e.g., %%{status}%%, {site}, etc.) as they serve specific purposes like Mailgun string replacement.
Applied to files:
ghost/i18n/locales/sv/ghost.json
📚 Learning: 2025-05-20T21:08:21.026Z
Learnt from: cathysarisky
PR: TryGhost/Ghost#0
File: :0-0
Timestamp: 2025-05-20T21:08:21.026Z
Learning: In the Ghost project, translation files (ghost/i18n/locales/*/*.json) commonly have blank values for translations, and this is normal behavior that should not be flagged in reviews. These empty translations will be filled in separate PRs.
Applied to files:
ghost/i18n/locales/sv/ghost.json
📚 Learning: 2025-07-29T04:57:10.163Z
Learnt from: kasnol
PR: TryGhost/Ghost#24523
File: ghost/i18n/locales/zh-Hant/comments.json:11-11
Timestamp: 2025-07-29T04:57:10.163Z
Learning: In Ghost's Traditional Chinese localization, the "Add your expertise" label appears as a link in comments when expertise is not yet provided, specifically to request additional professional background information from commenters. The translation should reflect this context of inviting additional information rather than just adding new information.
Applied to files:
ghost/i18n/locales/sv/comments.json
🔇 Additional comments (2)
ghost/i18n/locales/sv/ghost.json (2)
41-42: LGTM — accurate and idiomaticThese translations read well and keep placeholders intact:
- Sign in verification, Someone just replied…
- Upgrade / Upgrade to continue reading.
- When:/Where:
- Your verification code for {siteTitle}
- This message was sent from {siteDomain} to {email}.
- Here’s your code to login …
Also applies to: 55-56, 61-62, 76-76, 51-51, 20-20
2-77: Placeholders and keys look intact — thank youKeys and placeholder styles ({…}, %%{…}%%) appear preserved throughout, in line with Ghost i18n conventions.
If you have time, please cross-check that every key you translated exists in the English source for the same file (no extra/missing keys). I can provide a quick script to diff key sets if helpful.
cathysarisky
left a comment
cathysarisky
left a comment
There was a problem hiding this comment.
📋 My AI helper 🤖 left you a few comments. I always believe the human over the AI, so feel free to disregard them after you take a careful look! (I suspect the AI is wrong about prepositions, but right about punctuation!)
Leave me a comment or request review when you're satisfied with everything, please. :)
🤖 AI: Overall the translations are clear and consistent in tone. I did notice a few missing punctuation marks (colons and periods) and some preposition choices that might benefit from review for natural Swedish phrasing. Great work on keeping variables intact and respecting the friendly voice! Tack!
Drafted with my new i18n tooling - feedback welcome
ghost/i18n/locales/sv/ghost.json
Outdated
| "{date}": "{date}", | ||
| "All the best!": "Allt gott!", | ||
| "Become a paid member of {site} to get access to all premium content.": "", | ||
| "Become a paid member of {site} to get access to all premium content.": "Bli betalande medlem på {site} för att få tillgång till allt innehåll", |
There was a problem hiding this comment.
🤖 AI: The English string ends with a period, but the Swedish translation is missing it. Please add a period at the end: "Bli betalande medlem på {site} för att få tillgång till allt innehåll."
ghost/i18n/locales/sv/ghost.json
Outdated
| "Confirm your email update for {siteTitle}!": "Bekräfta din uppdatering av e-postadress för {siteTitle}!", | ||
| "Confirm your subscription to {siteTitle}": "Bekräfta din prenumeration på {siteTitle}", | ||
| "Device:": "", | ||
| "Device:": "Enhet", |
There was a problem hiding this comment.
🤖 AI: The original has a colon after "Device". Please include the colon in Swedish: "Enhet:"
| "New comment on {postTitle}": "", | ||
| "New reply to your comment on {siteTitle}": "", | ||
| "New comment on {postTitle}": "Ny kommentar i {postTitle}", | ||
| "New reply to your comment on {siteTitle}": "Nytt svar till din kommentar på {siteTitle}", |
There was a problem hiding this comment.
🤖 AI: In "Nytt svar till din kommentar på {siteTitle}", consider whether "svar på din kommentar" reads more naturally than "svar till".
There was a problem hiding this comment.
Torn on this one. You'd probably try to say something else altogether in Swedish if you want it to sound natural. Still till -> på is probably better, even though you end up with a "på ... på".
There was a problem hiding this comment.
If there is a rewording on this that makes it better Swedish, that's totally OK. We want something with the same meaning, but it doesn't need to have the same phrasing.
| "Someone just replied to your comment on {postTitle}.": "", | ||
| "Sign in verification": "Inloggningsverifiering", | ||
| "Someone just replied to your comment": "Någon svarade just på din kommentar", | ||
| "Someone just replied to your comment on {postTitle}.": "Någon svarade just på din kommentar i {postTitle}.", |
There was a problem hiding this comment.
🤖 AI: Similar preposition question: "i {postTitle}" vs. "på {postTitle}". Please verify the most natural choice.
There was a problem hiding this comment.
Same as above, repeating "på" sounds a bit off as well, but's it's more correct than i.
ghost/i18n/locales/sv/ghost.json
Outdated
| "You can unsubscribe from these notifications at {profileUrl}.": "", | ||
| "You just tried to access your account from a new device.": "", | ||
| "You can unsubscribe from these notifications at {profileUrl}.": "Du kan stänga av notifikationer på {profileUrl}.", | ||
| "You just tried to access your account from a new device.": "Du försöker logga in på ditt konto från en ny enhet.", |
There was a problem hiding this comment.
🤖 AI: The English is past tense "just tried" but the Swedish reads present tense "Du försöker logga in...". Please consider past tense such as "Du försökte logga in på ditt konto från en ny enhet."
| "Your subscription will expire on {date}.": "Din prenumeration kommer att löpa ut den {date}.", | ||
| "Your subscription will renew on {date}.": "Din prenumeration kommer att förnyas den {date}.", | ||
| "Your verification code for {siteTitle}": "" | ||
| "Your verification code for {siteTitle}": "Din verifieringskod till {siteTitle}" |
There was a problem hiding this comment.
🤖 AI: In "Din verifieringskod till {siteTitle}", perhaps "för {siteTitle}" would match the English "code for" more directly: "Din verifieringskod för {siteTitle}". Please check.
|
Hello Cathy,
I’m a newbie on github but I will do my best.
Thank you for the human reply.
Sincerely
Martin
fre 22 aug. 2025 kl. 16:59 skrev Cathy Sarisky ***@***.***>:
… ***@***.**** requested changes on this pull request.
📋 My AI helper 🤖 left you a few comments. I always believe the human
over the AI, so feel free to disregard them after you take a careful look!
(I suspect the AI is wrong about prepositions, but right about punctuation!)
Leave me a comment or request review when you're satisfied with
everything, please. :)
🤖 AI: Overall the translations are clear and consistent in tone. I did
notice a few missing punctuation marks (colons and periods) and some
preposition choices that might benefit from review for natural Swedish
phrasing. Great work on keeping variables intact and respecting the
friendly voice! Tack!
------------------------------
*Drafted with my new i18n tooling - feedback welcome*
------------------------------
In ghost/i18n/locales/sv/comments.json
<#24723 (comment)>:
> @@ -42,15 +42,15 @@
"Member discussion": "Medlemsdiskussion",
"Name": "Namn",
"Neurosurgeon": "Neurokirurg",
- "Newest": "",
- "Oldest": "",
- "Once deleted, this comment can’t be recovered.": "",
+ "Newest": "Nyast",
+ "Oldest": "Äldst",
+ "Once deleted, this comment can’t be recovered.": "Kommentar kan ej återskapas efter borttagning",
🤖 AI: The original ends with a period. Please add a final period to the
translation: "Kommentar kan ej återskapas efter borttagning."
------------------------------
In ghost/i18n/locales/sv/comments.json
<#24723 (comment)>:
> "One hour ago": "En timme sedan",
"One min ago": "En minut sedan",
- "removed": "",
- "Replied to": "",
+ "removed": "borttagen",
+ "Replied to": "Svarade till",
🤖 AI: Is "Svarade till" the most natural Swedish for "Replied to"?
Typically one says "svarade på". Please verify that this preposition is
correct in context.
------------------------------
In ghost/i18n/locales/sv/comments.json
<#24723 (comment)>:
> "Reply": "Svar",
- "Reply to": "",
+ "Reply to": "Svara till",
🤖 AI: Similar to above: "Reply to" might be more naturally translated as
"Svara på" rather than "Svara till". Please check if "på" is more
appropriate here.
------------------------------
In ghost/i18n/locales/sv/ghost.json
<#24723 (comment)>:
> @@ -1,7 +1,7 @@
{
"{date}": "{date}",
"All the best!": "Allt gott!",
- "Become a paid member of {site} to get access to all premium content.": "",
+ "Become a paid member of {site} to get access to all premium content.": "Bli betalande medlem på {site} för att få tillgång till allt innehåll",
🤖 AI: The English string ends with a period, but the Swedish translation
is missing it. Please add a period at the end: "Bli betalande medlem på
{site} för att få tillgång till allt innehåll."
------------------------------
In ghost/i18n/locales/sv/ghost.json
<#24723 (comment)>:
> @@ -12,12 +12,12 @@
"Confirm your email address": "Bekräfta din e-postadress",
"Confirm your email update for {siteTitle}!": "Bekräfta din uppdatering av e-postadress för {siteTitle}!",
"Confirm your subscription to {siteTitle}": "Bekräfta din prenumeration på {siteTitle}",
- "Device:": "",
+ "Device:": "Enhet",
🤖 AI: The original has a colon after "Device". Please include the colon
in Swedish: "Enhet:"
------------------------------
In ghost/i18n/locales/sv/ghost.json
<#24723 (comment)>:
> "Email": "E-post",
- "For security verification, enter the code below to sign in to {siteTitle}:": "",
+ "For security verification, enter the code below to sign in to {siteTitle}:": "Av säkerhetskäl behöver du ange koden nedan för att logga in till {siteTitle}",
🤖 AI: The English ends with a colon and uses "to sign in to". The
translation is missing the colon and uses "logga in till". It might be
clearer as "...ange koden nedan för att logga in på {siteTitle}:". Please
consider adding the colon and adjusting the preposition.
------------------------------
In ghost/i18n/locales/sv/ghost.json
<#24723 (comment)>:
> @@ -29,41 +29,41 @@
"Member since": "Medlem sen",
"More like this": "Mer av det här",
"Name": "Namn",
- "New comment on {postTitle}": "",
- "New reply to your comment on {siteTitle}": "",
+ "New comment on {postTitle}": "Ny kommentar i {postTitle}",
🤖 AI: You’ve used "i" for "on" in "Ny kommentar i {postTitle}". Would
"på" be more natural here ("Ny kommentar på {postTitle}")? Please check.
------------------------------
In ghost/i18n/locales/sv/ghost.json
<#24723 (comment)>:
> @@ -29,41 +29,41 @@
"Member since": "Medlem sen",
"More like this": "Mer av det här",
"Name": "Namn",
- "New comment on {postTitle}": "",
- "New reply to your comment on {siteTitle}": "",
+ "New comment on {postTitle}": "Ny kommentar i {postTitle}",
+ "New reply to your comment on {siteTitle}": "Nytt svar till din kommentar på {siteTitle}",
🤖 AI: In "Nytt svar till din kommentar på {siteTitle}", consider whether
"svar på din kommentar" reads more naturally than "svar till".
------------------------------
In ghost/i18n/locales/sv/ghost.json
<#24723 (comment)>:
> "paid": "betalande",
"Please confirm your email address with this link:": "Vänligen bekräfta din e-postadress med denna länk:",
"Secure sign in link for {siteTitle}": "Säker inloggningslänk för {siteTitle}",
"See you soon!": "Vi ses snart!",
"Sent to {email}": "Skickat till {email}",
"Sign in": "Logga in",
"Sign in to {siteTitle}": "Logga in på {siteTitle}",
- "Sign in verification": "",
- "Someone just replied to your comment": "",
- "Someone just replied to your comment on {postTitle}.": "",
+ "Sign in verification": "Inloggningsverifiering",
+ "Someone just replied to your comment": "Någon svarade just på din kommentar",
+ "Someone just replied to your comment on {postTitle}.": "Någon svarade just på din kommentar i {postTitle}.",
🤖 AI: Similar preposition question: "i {postTitle}" vs. "på {postTitle}".
Please verify the most natural choice.
------------------------------
In ghost/i18n/locales/sv/ghost.json
<#24723 (comment)>:
> "trialing": "prov",
"Unsubscribe": "Avanmäl",
- "Unsubscribe from comment reply notifications": "",
- "Upgrade": "",
- "Upgrade to continue reading.": "",
- "View comments": "",
+ "Unsubscribe from comment reply notifications": "Avböj notifikation vid svar på kommentar",
🤖 AI: For consistency with other "Unsubscribe" translations (e.g.
"Avanmäl"), is "Avböj notifikation vid svar på kommentar" the best choice?
Please check wording and plurality.
------------------------------
In ghost/i18n/locales/sv/ghost.json
<#24723 (comment)>:
> "You are receiving this because you are a <strong>%%{status}%% subscriber</strong> to {site}.": "Du får det här eftersom du är en <strong>%%{status}%% medlem</strong> på {site}.",
"You can also copy & paste this URL into your browser:": "Du kan också kopiera och klistra in denna webbadress i din webbläsare:",
- "You can unsubscribe from these notifications at {profileUrl}.": "",
- "You just tried to access your account from a new device.": "",
+ "You can unsubscribe from these notifications at {profileUrl}.": "Du kan stänga av notifikationer på {profileUrl}.",
+ "You just tried to access your account from a new device.": "Du försöker logga in på ditt konto från en ny enhet.",
🤖 AI: The English is past tense "just tried" but the Swedish reads
present tense "Du försöker logga in...". Please consider past tense such as
"Du försökte logga in på ditt konto från en ny enhet."
------------------------------
In ghost/i18n/locales/sv/ghost.json
<#24723 (comment)>:
> @@ -73,5 +73,5 @@
"Your subscription has expired.": "Din prenumeration har löpt ut.",
"Your subscription will expire on {date}.": "Din prenumeration kommer att löpa ut den {date}.",
"Your subscription will renew on {date}.": "Din prenumeration kommer att förnyas den {date}.",
- "Your verification code for {siteTitle}": ""
+ "Your verification code for {siteTitle}": "Din verifieringskod till {siteTitle}"
🤖 AI: In "Din verifieringskod till {siteTitle}", perhaps "för
{siteTitle}" would match the English "code for" more directly: "Din
verifieringskod för {siteTitle}". Please check.
—
Reply to this email directly, view it on GitHub
<#24723 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APCY6QHTKXJ5XK3V2TS4SQT3O4V6LAVCNFSM6AAAAACEOGH5YKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNBUGY4TMMZRGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No problem! If you get stuck, just let me know. The process for revising is to open the code again (same process as you used before), make your changes, and be very sure to commit your changes, which will cause them to show up here on the PR. (If you don't see them here on the pull request, you've probably missed the commit step.) |
jonatansberg
left a comment
jonatansberg
left a comment
There was a problem hiding this comment.
Hej Martin!
Thank you for taking the time to help out improving our translations. I'm a Swedish native as well and just joined the Ghost team. I've had a standing item on my mental todo list to look over these translations, but you beat me to it 😊
Overall I think this looks good. There are some specific wordings that I think would make sense to tweak. Please let me know what you think.
| "Become a member of {publication} to start commenting.": "Registrera dig på {publication} för att börja kommentera.", | ||
| "Become a paid member of {publication} to start commenting.": "Bli betalande medlem på {publication} för att börja kommentera ", | ||
| "Best": "", | ||
| "Best": "Mest populär", |
There was a problem hiding this comment.
Wouldn't "Bästa" be closer to the original?
There was a problem hiding this comment.
You are right, it's closer to the original. But is it the best?
From context.json
"Best": "Text appears in the sorting selector for comments"
By taking a philosophic argument (saw on your site that you studied philosophy in Gothenburg:) ...
does the top-voted comment need to be "bäst"? In my opinion "Mest populär" clings more real...
| "Device:": "Enhet", | ||
| "Email": "E-post", | ||
| "For security verification, enter the code below to sign in to {siteTitle}:": "", | ||
| "For security verification, enter the code below to sign in to {siteTitle}:": "Av säkerhetskäl behöver du ange koden nedan för att logga in till {siteTitle}", |
There was a problem hiding this comment.
+1 on till -> på, thats already whats used on line 20
| "New comment on {postTitle}": "", | ||
| "New reply to your comment on {siteTitle}": "", | ||
| "New comment on {postTitle}": "Ny kommentar i {postTitle}", | ||
| "New reply to your comment on {siteTitle}": "Nytt svar till din kommentar på {siteTitle}", |
There was a problem hiding this comment.
Torn on this one. You'd probably try to say something else altogether in Swedish if you want it to sound natural. Still till -> på is probably better, even though you end up with a "på ... på".
| "Someone just replied to your comment on {postTitle}.": "", | ||
| "Sign in verification": "Inloggningsverifiering", | ||
| "Someone just replied to your comment": "Någon svarade just på din kommentar", | ||
| "Someone just replied to your comment on {postTitle}.": "Någon svarade just på din kommentar i {postTitle}.", |
There was a problem hiding this comment.
Same as above, repeating "på" sounds a bit off as well, but's it's more correct than i.
|
Hey @sMaX2016 , just checking in to see if you've had time to look at the recommendations from @jonatansberg (thank you!), so that we can get this thing moved along. It also has some merge conflicts that need to be resolved (click the "resolve conflicts" button to see and correct). Thanks! |
Hello @cathysarisky ! Regarding the rest I would like for @jonatansberg to have another look. I made thumbs up for the ones where I totally agree with Jonatans input. Wish you a good day, |
|
Hi @sMaX2016 , sorry for the delayed reply. I resolved the merge conflict issue for you. That happens when new strings are added after a PR is submitted. It's nothing you did wrong, just an effect of time passing. For the places where you and @jonatansberg agree, please go ahead and update your PR. You do that by opening the file again, making the edit, and the committing the change, which should update the PR. (If you don't see it when you look at the 'files changed' section of the PR, then you have probably missed the commit step.) Where you don't agree, please reply to your reviewer and get some discussion going. Why do you like your way better? Thanks! |
|
I did the changes in my branch and followed the youtube video "How to help translate Ghost" to do PR but when I start a "new pull request" and "compare across forks" to do a PR between my clone and main I just get the green button "View Pulled request". Anyway, there is some updates in my branch. |
|
Ah, I see. So you just need to commit those changes to the same branch as the one in the existing PR, and they should get added. :) Update: Looks like you did that! |
|
Thanks for contributing to Ghost's i18n :) This PR has been automatically marked as stale because there has not been any activity here in 3 weeks. If you're still interested in working on this PR, please let us know. Otherwise this PR will be closed shortly, but can always be reopened later. Thank you for understanding 🙂 |
github-actions
bot
added
the
stale
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| "Device:": "Enhet:", | ||
| "Email": "E-post", | ||
| "For security verification, enter the code below to sign in to {siteTitle}:": "", | ||
| "For security verification, enter the code below to sign in to {siteTitle}:": "Av säkerhetskäl behöver du ange koden nedan för att logga in till {siteTitle}", |
There was a problem hiding this comment.
Bug: Swedish Translation Inconsistencies
The new Swedish translations have a couple of consistency issues. The translation for "For security verification, enter the code below to sign in to {siteTitle}:" omits the trailing colon, inconsistent with the English source and other Swedish entries. Additionally, the preposition for "sign in to {siteTitle}" is inconsistently translated as "till" in one place and "på" in others, affecting messaging.
cathysarisky
left a comment
cathysarisky
left a comment
There was a problem hiding this comment.
Hi @jonatansberg @sMaX2016 !
Stalebot is about to close this PR. Any further changes? If not, I'm going to go ahead and merge, because the places where there's some disagreement on prepositions are replacing missing strings, and slightly awkward Swedish is probably better than English?
| "New comment on {postTitle}": "", | ||
| "New reply to your comment on {siteTitle}": "", | ||
| "New comment on {postTitle}": "Ny kommentar i {postTitle}", | ||
| "New reply to your comment on {siteTitle}": "Nytt svar till din kommentar på {siteTitle}", |
There was a problem hiding this comment.
If there is a rewording on this that makes it better Swedish, that's totally OK. We want something with the same meaning, but it doesn't need to have the same phrasing.
github-actions
bot
removed
the
stale
4 participants
I checked context for some of the sentences, but not all...
I'm swedish, working extra as a swedish teacher, so I'm pretty sure the language will be right.