-
-
Notifications
You must be signed in to change notification settings - Fork 155
test: add vitest as test framework and port current tests #977
Conversation
the tests are not correctly calling the `parse` method currently
@pano9000 , kind reminder that you have write rights on the repo. You can push directly on a branch on TriliumNext/Notes instead of on your fork. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
Two tests are failing on my side, on Windows, but it's a pretty good start.
I wonder: which ones are failing? |
@pano9000 , since the last PRs were merged, only one of them is failing:
The tests for the directories appear a bit complicated, especially with the |
that was mainly, because those tests were written with the Now that we have the mocks -> I've simplified it a bit for you ;-) Regarding the failing test: that is interesting – will need to check on a Windows machine some time |
Hi,
this PR aims to introduce
vitest
as test framework for the project – replacing the "previous selfmade test runner" and "jasmine".See discussion here for more details
https://github.com/orgs/TriliumNext/discussions/925
Additional bonus:
We now have test coverage reports, by using
npm run test-coverage