-
Notifications
You must be signed in to change notification settings - Fork 241
Feat!: Tag queries with their plan id #4832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good. Is the next step to manually intercept the adapter instantiations elsewhere (e.g., unit tests), to ensure the IDs are properly generated in their execute
as well?
That's right, the first iteration covers only the snapshot evaluator for now. Subsequent iterations can also include the engine adapters in EDIT: Actually, intercepting the unit test queries may not be straightforward because they've ran well before the plan id has been generated. |
b5424e8
to
640ef92
Compare
This PR enhances the
SnapshotEvaluator
such that it appends a comment containing theplan_id
at each query generated under it.This can help associate historical queries with a plan after the fact and paves the way for tagging queries with labels/tags in engines like BigQuery and Snowflake.