Chore: add no-op extras for duckdb and motherduck #4829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duckdb is included in the core sqlmesh dependencies, so neither the duckdb nor motherduck engines require installing a pip extra. However, that may not be obvious to users, and they still attempt a
pip install "sqlmesh[duckdb]".Currently, that gives a pip error, which is misleading. This PR adds no-op extras for duckdb/motherduck so the error does not occur.
Note: spark does not require an extra install, but its dependencies are NOT included in core sqlmesh. Therefore, the PR does not add a spark no-op extra. That way, the user encounters the dependency errors while performing installation (rather than later when they are actually trying to use sqlmesh).