fix mock release test #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisStaratzis
force-pushed
the
dstara/fix_mock_release_testing
branch
from
0c1736a to
b44eaf7
Compare
DimitrisStaratzis
force-pushed
the
dstara/fix_mock_release_testing
branch
from
5d03e9b to
aae0679
Compare
DimitrisStaratzis
force-pushed
the
dstara/fix_mock_release_testing
branch
from
aae0679 to
f59874f
Compare
DimitrisStaratzis
force-pushed
the
dstara/fix_mock_release_testing
branch
from
5795fa0 to
f94d49b
Compare
DimitrisStaratzis
force-pushed
the
dstara/fix_mock_release_testing
branch
from
7c6d4c4 to
6cc1933
Compare
DimitrisStaratzis
force-pushed
the
dstara/fix_mock_release_testing
branch
from
bfc899a to
e7dde5d
Compare
DimitrisStaratzis
force-pushed
the
dstara/fix_mock_release_testing
branch
from
e7dde5d to
85896c4
Compare
DimitrisStaratzis
force-pushed
the
dstara/fix_mock_release_testing
branch
from
c1e422a to
a190d65
Compare
DimitrisStaratzis
force-pushed
the
dstara/fix_mock_release_testing
branch
from
4519877 to
d3ef682
Compare
ihnorton
reviewed
Nov 28, 2023
ihnorton
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the step that was testing the release was using an outdated version of
set-up-javaand that was causing it to download an x86_64 version of Java in arm runners. I will open a new PR to add dependabot in this repo.On top of that, the
NativeLibLoaderwas lacking a/in the path to be able to locate the native libs in apple silicon macs.