use Linux binaries without avx2 by default #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisStaratzis
force-pushed
the
dstara/use_noavx_linux_binaries
branch
from
55c90df to
3beb4c6
Compare
ihnorton
reviewed
Nov 8, 2023
cmake/Modules/FindTileDB_EP.cmake
Outdated
| @@ -64,8 +64,8 @@ if (NOT TILEDB_FOUND) | |||
| endif() | |||
|
|
|||
| else() # Linux | |||
| SET(DOWNLOAD_URL "https://github.com/TileDB-Inc/TileDB/releases/download/2.17.4/tiledb-linux-x86_64-2.17.4-a1f648e.tar.gz") | |||
| SET(DOWNLOAD_SHA1 "7849cbbf19f5f9252e4be5350328754b01938aaa") | |||
| SET(DOWNLOAD_URL "https://github.com/TileDB-Inc/TileDB/releases/download/2.17.4/tiledb-linux-x86_64-noavx2-2.17.4-a1f648e.tar.gz") | |||
There was a problem hiding this comment.
I believe you'll need to add an alternate URL for the other set of binaries in order for grade to use them, right?
There was a problem hiding this comment.
yes exactly. Will push shortly
DimitrisStaratzis
force-pushed
the
dstara/use_noavx_linux_binaries
branch
3 times, most recently
from
237273c to
54469bd
Compare
DimitrisStaratzis
force-pushed
the
dstara/use_noavx_linux_binaries
branch
from
54469bd to
0f09402
Compare
DimitrisStaratzis
changed the title
ihnorton
approved these changes
Nov 8, 2023
CMakeLists.txt
Outdated
| @@ -55,6 +55,7 @@ option(TILEDB_GIT_TAG "Git tag to use for building" "") | |||
| option(FORCE_BUILD_TILEDB "Force building TileDB and don't check for system installation" OFF) | |||
| option(DOWNLOAD_TILEDB_PREBUILT "If tiledb is being super built, this controls downloading prebuilt artifacts or building from source" ON) | |||
| option(TILEDB_SKIP_S3AWSSDK_DIR_LENGTH_CHECK "If true, skip check needed path length for awssdk (TILEDB_S3) dependent builds" OFF) | |||
| option(USE_AVX2 "If true TileDB-Java will use the Linux binaries with AVX2" OFF) | |||
There was a problem hiding this comment.
nit: "precompiled" (if we build from source the architecture will match the current CPU)
DimitrisStaratzis
force-pushed
the
dstara/use_noavx_linux_binaries
branch
from
0f09402 to
0de1529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make the Java API to use the Linux noavx2 binaries by default. This resolves #309. Also introduced the
USE_AVX2gradle property.