adding new Query Condition constructor that replaces Class with tiledb.Datatype #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
requested changes
Jul 5, 2023
DimitrisStaratzis
force-pushed
the
dstara/change_qc_constructor_datatype_param
branch
from
a8b6e5c to
db0ddd1
Compare
DimitrisStaratzis
changed the title
DimitrisStaratzis
changed the title
ihnorton
reviewed
Jul 5, 2023
DimitrisStaratzis
force-pushed
the
dstara/change_qc_constructor_datatype_param
branch
from
db0ddd1 to
ed67b37
Compare
ihnorton
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API improvement. Previous implementation could lead user to not be able to fully control the datatype in the Query Condition as they would pass a Class object which was then internally translated to a TileDB datatype. This unnecessary middle step is now removed.
Tests have also been modified to use the new constructor.