Skip to content

NIO ByteBuffer support for variable-sized attributes #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2020
Merged

NIO ByteBuffer support for variable-sized attributes #183

merged 5 commits into from
Jul 15, 2020

Conversation

gsvic
Copy link
Contributor

@gsvic gsvic commented Jul 13, 2020

This PR includes the following:

  1. Added ByteBuffer support for var-sized attributes/dimensions
  2. Changed setBuffer method to return the Query instance instead of the ByteBuffer.

@gsvic gsvic requested a review from Shelnutt2 July 13, 2020 18:19
@gsvic gsvic force-pushed the victorgiannakouris/bytebuffer_var branch from 01dc77b to 37f2c83 Compare July 13, 2020 19:20
@gsvic gsvic force-pushed the victorgiannakouris/bytebuffer_var branch from eaf3f5f to 61c0e71 Compare July 13, 2020 20:35
@gsvic gsvic force-pushed the victorgiannakouris/bytebuffer_var branch from 61c0e71 to c5d79aa Compare July 13, 2020 20:42
@gsvic gsvic merged commit 33f63c0 into master Jul 15, 2020
@gsvic gsvic deleted the victorgiannakouris/bytebuffer_var branch July 17, 2020 15:05
@gsvic gsvic mentioned this pull request Jul 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shelnutt2 Shelnutt2 Shelnutt2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsvic @Shelnutt2