Skip to content

Publish to Maven Central #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Publish to Maven Central #172

merged 1 commit into from
Jun 17, 2020

Conversation

gsvic
Copy link
Contributor

@gsvic gsvic commented Jun 17, 2020

No description provided.

@gsvic gsvic requested a review from Shelnutt2 June 17, 2020 16:49
build.gradle Outdated
@@ -10,7 +10,7 @@ plugins {
}

group 'io.tiledb'
version '0.2.8-SNAPSHOT'
version '0.2.8-test4-SNAPSHOT'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

build.gradle Outdated
@@ -158,6 +153,7 @@ artifacts {
import org.gradle.plugins.signing.Sign
gradle.taskGraph.whenReady { taskGraph ->
if (taskGraph.allTasks.any { it instanceof Sign }) {
println System.getenv('GPG_KEY_ID')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@gsvic gsvic force-pushed the victorgiannakouris/maven_upload branch from b634567 to b6fac15 Compare June 17, 2020 16:50
@gsvic gsvic force-pushed the victorgiannakouris/maven_upload branch from b6fac15 to 736173a Compare June 17, 2020 16:52
@gsvic gsvic requested a review from Shelnutt2 June 17, 2020 16:53

- bash: |
echo "USERNAME"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

- bash: |
echo "USERNAME"
echo $SONATYPE_USERNAME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Copy link
Member

@Shelnutt2 Shelnutt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more comments, then lgtm

@gsvic gsvic merged commit fc1eae2 into master Jun 17, 2020
@Shelnutt2 Shelnutt2 deleted the victorgiannakouris/maven_upload branch June 17, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants