-
Notifications
You must be signed in to change notification settings - Fork 5
Windows build #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Windows build #165
Changes from 34 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
851a4ea
Groovyify cmake properties handling
chris-allan 4e15458
Add capability to set cmake generator and architecture
chris-allan 386e66b
Switch build phase to cmake
chris-allan 6cbbb61
Expand native library search paths for cmake/Windows
chris-allan 7fc393d
Add AppVeyor build
chris-allan 27dbcf4
MSVC requires explicit cast
chris-allan 58d4a9d
Set the object export environment correctly
chris-allan 134ae62
Run tests on AppVeyor
chris-allan 84cbf26
JAR paths always use UNIX path separators (Windows compat)
chris-allan 68a8a85
Use correct path separators and delimiters for Windows
chris-allan e2acea1
Also load Intel Thread Building Blocks library (Windows compat)
chris-allan a9fc264
Config File/URI usage refactoring (Windows compat)
chris-allan 53c00c8
Clean up ObjectTest (Windows compat)
chris-allan 074f96b
Clean up HeterogeneousSparseTest (Windows compat)
chris-allan 6cf5b73
Clean up MultiRangeQueryTest (Windows compat)
chris-allan 5df7c0d
Clean up QueryTest (Windows compat)
chris-allan 821d027
Clean up Quickstart*Test (Windows compat)
chris-allan 37cf9cc
Clean up VFSTest (Windows compat)
chris-allan c3b32a4
Upgrade to Gradle 6.4.1
chris-allan 11eb8e9
Fix segfault on Windows and possible memory leak
chris-allan d79ecda
Set max heap size
chris-allan 2170c49
More information if assertion fails
chris-allan 5124838
Resource closure during tests
chris-allan 4a676a4
Try waiting slightly longer to pass on CI
chris-allan 734a804
Try slightly different resource close semantics
chris-allan 063a1fb
System.currentTimeMillis() is already UTC
chris-allan 1cafcf4
Try waiting after not before
chris-allan 05520c2
Gradle 7 compat
chris-allan a1c1e35
Test NativeLibLoader functions correctly
chris-allan a95248e
Refactor NativeLibLoader to use a folder based workflow (Windows compat)
chris-allan 686fcc4
Set CLASSPATH separately with globbing
chris-allan 8085f4b
Ensure buildDir presence in Gradle
chris-allan f1413ef
More verbosity when running tests
chris-allan 1abbc5d
Try waiting a second before and a second after
chris-allan b7633bc
Update Google Java Style plugin
chris-allan 29781f6
Make formatting conform to Google Java Style
chris-allan 7654e98
Add constructor for time-travelling without encryption
chris-allan 90e6f14
Adjust test cases to use explicit timestamps
chris-allan a40e3ef
Try with default max heap
chris-allan a973cc6
Revert "Try with default max heap"
chris-allan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,5 @@ build/* | |
.project | ||
.settings | ||
bin/ | ||
/.gradle/ | ||
/build/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
version: 0.2.7.{build} | ||
|
||
image: Visual Studio 2019 | ||
platform: | ||
- x64 | ||
|
||
build: off | ||
|
||
build_script: | ||
- gradlew assemble | ||
|
||
test_script: | ||
- gradlew --info test | ||
# Check that the NativeLibLoader functions correctly | ||
- ps: $(ls build\libs\tiledb-java-*.jar | % {$Env:CLASSPATH += $_.FullName + ";"}) | ||
- ps: java examples.io.tiledb.java.api.TileDBVersion | ||
|
||
artifacts: | ||
- path: 'build\libs\*' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.4.1-all.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,5 +13,4 @@ pluginManagement { | |
} | ||
} | ||
} | ||
enableFeaturePreview('STABLE_PUBLISHING') | ||
rootProject.name = 'tiledb-java' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you find that we needed to set the maxHeapSize in your environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did, but that was before I refactored a lot of the resource handling into try-with-resources blocks and when I had a lot of tests failing. I'll push a commit without and we'll see if that passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without
maxHeapSize = '1G'
, fails with an OOM:I can roll a40e3ef back or we can try something else if you'd like.