Skip to content

Victorgiannakouris/ch648/support open at for arrays #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 13, 2019

Conversation

gsvic
Copy link
Contributor

@gsvic gsvic commented Nov 21, 2019

Clubhouse Link

https://app.clubhouse.io/tiledb-inc/story/648/support-open-at-for-arrays

Story ID

648

Description

This PR contains the implementation of the time-travelling feature in Java API.

@gsvic gsvic requested a review from Shelnutt2 November 21, 2019 19:20
Copy link
Member

@Shelnutt2 Shelnutt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a second Array constructor which can open encrypted arrays with a timestamp also.

Can you add new unit tests for both new constructors?

@Shelnutt2
Copy link
Member

Also you need to format the files with ./gradlew format

https://travis-ci.org/TileDB-Inc/TileDB-Java/jobs/615217287?utm_medium=notification&utm_source=github_status

@gsvic gsvic closed this Dec 13, 2019
@gsvic gsvic reopened this Dec 13, 2019
@Shelnutt2 Shelnutt2 merged commit 755575a into master Dec 13, 2019
@Shelnutt2 Shelnutt2 deleted the victorgiannakouris/ch648/support-open-at-for-arrays branch December 13, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants